From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Jeff King <peff@peff.net>
Cc: "Kirill A. Korinskiy" <catap@catap.ru>, git@vger.kernel.org
Subject: Re: [PATCH] Add option -b/--branch to clone for select a new HEAD
Date: Wed, 26 Aug 2009 18:56:18 +0200 [thread overview]
Message-ID: <20090826165618.GA7477@atjola.homenet> (raw)
In-Reply-To: <20090826161059.GC32741@coredump.intra.peff.net>
On 2009.08.26 12:10:59 -0400, Jeff King wrote:
> So I think the code should probably look like this (totally untested):
>
> remote_head = find_ref_by_name(refs, "HEAD");
> if (option_branch) {
> strbuf_addf(&branch_head, "%s%s", src_ref_prefix, option_branch);
> head_points_at = find_ref_by_name(refs, branch_head.buf);
> if (!head_points_at)
> warning("remote branch not found, etc");
> }
> if (!head_points_at)
> head_points_at = guess_remote_head(remote_head, mapped_refs, 0);
Hm, why "refs" for find_ref_by_name(), but "mapped_ref" for
guess_remote_head()?
Björn
next prev parent reply other threads:[~2009-08-26 16:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87praj90n8.wl%catap@catap.ru>
2009-08-25 19:25 ` [PATCH] Add option -b/--branch to clone for select a new HEAD Kirill A. Korinskiy
2009-08-25 19:27 ` Kirill A. Korinskiy
2009-08-25 21:57 ` Jeff King
2009-08-25 22:42 ` Junio C Hamano
2009-08-25 22:36 ` Björn Steinbrink
[not found] ` <87ljl694fd.wl%catap@catap.ru>
2009-08-26 12:16 ` Björn Steinbrink
2009-08-26 14:46 ` Kirill A. Korinskiy
2009-08-26 15:50 ` Björn Steinbrink
2009-08-26 16:10 ` Jeff King
2009-08-26 16:56 ` Björn Steinbrink [this message]
2009-08-26 17:48 ` Jeff King
2009-08-26 19:05 ` Jeff King
2009-08-28 10:31 ` Tor Arne Vestbø
2009-08-28 11:05 ` Martin Langhoff
2009-08-28 12:10 ` Julian Phillips
2009-08-24 20:42 Kirill A. Korinskiy
2009-08-25 1:57 ` Jeff King
2009-08-25 2:13 ` Junio C Hamano
2009-08-25 17:20 ` Kirill A. Korinskiy
2009-08-25 19:00 ` Jeff King
2009-08-25 12:30 ` Kirill A. Korinskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826165618.GA7477@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=catap@catap.ru \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).