From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jari Aalto <jari.aalto@cante.net>, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms
Date: Sun, 30 Aug 2009 17:02:31 -0400 [thread overview]
Message-ID: <20090830210231.GA4471@coredump.intra.peff.net> (raw)
In-Reply-To: <7vab1hdppb.fsf@alter.siamese.dyndns.org>
On Sun, Aug 30, 2009 at 01:14:24PM -0700, Junio C Hamano wrote:
> > - operation to a subset of the working tree. See ``Interactive
> > - mode'' for details.
> > + operation to a subset of the working tree. See section
> > + ``INTERACTIVE MODE'' for details.
>
> Sorry, the change in this hunk does not make *any* sense to me.
>
> It is not justified with your commit log message, I do not see why you
> have to shout in all CAPS, and there is no such section in the
> documentation. But the "Interactive mode" section exists and is referred
> to by the original.
I think it is an attempt to match the way docbook renders manpage
headings; it converts headings to all-caps. And there is some precedent;
try grepping for ".EXAMPLES" in Documentation/*.txt.
That being said, the straight asciidoc->html version leaves the
capitalization untouched. However, that actually makes the html version
look quite awkward. Some of the headings are in all-caps and some are
not. So I wonder if we should make them typographically consistent.
(And yes, I totally agree that this hunk was a surprise after reading
the commit message and if anything is done, it should be in a separate
patch).
-Peff
next prev parent reply other threads:[~2009-08-30 21:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 17:29 [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms Jari Aalto
2009-08-30 20:14 ` Junio C Hamano
2009-08-30 21:02 ` Jeff King [this message]
2009-08-30 21:56 ` Jari Aalto
2009-08-30 22:13 ` Junio C Hamano
2009-08-30 23:06 ` Jari Aalto
2009-08-30 23:20 ` Junio C Hamano
2009-08-31 7:46 ` Jari Aalto
2009-08-31 23:42 ` Junio C Hamano
2009-09-13 6:44 ` [PATCH] Improve --patch option documentation in git-add Jari Aalto
2009-09-13 13:48 ` Mikael Magnusson
2009-09-13 14:09 ` Jari Aalto
2009-09-14 13:13 ` Sean Estabrooks
2009-09-15 5:35 ` [PATCH] Improve --patch option documentation in git-add (updated patch) Jari Aalto
2009-09-15 6:52 ` Nanako Shiraishi
2009-09-15 8:17 ` Jari Aalto
2009-09-15 10:35 ` Nanako Shiraishi
2009-08-30 23:31 ` [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms Junio C Hamano
2009-08-31 7:06 ` Jari Aalto
2009-08-31 7:32 ` Junio C Hamano
2009-08-30 22:00 ` Jari Aalto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090830210231.GA4471@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).