From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Yann Dirson <ydirson@linagora.com>, git@vger.kernel.org
Subject: Re: [BUG] git stash refuses to save after "add -N"
Date: Mon, 31 Aug 2009 01:05:54 -0400 [thread overview]
Message-ID: <20090831050554.GA17197@coredump.intra.peff.net> (raw)
In-Reply-To: <7vljl0lgms.fsf@alter.siamese.dyndns.org>
On Sun, Aug 30, 2009 at 10:03:07PM -0700, Junio C Hamano wrote:
> > - "-f" is kind of vague. Would people expect it to force aspects of
> > the stash? Should it be "--intent-as-empty"?
>
> I am not sure if asking for positive confirmation with "-f" is even worth
> it. As you pointed out in your earlier message, which prompted me to
> respond with a patch, when this codepath is exercised, the user is in a
> rush, and I do not see what else the user would want to do other than
> including it in the stash by rerunning with -f.
I guess it was just to mitigate my fear that we are somehow creating a
stash that will confuse people when they apply it. But really that fear
is probably unjustified.
-Peff
next prev parent reply other threads:[~2009-08-31 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 11:02 [BUG] git stash refuses to save after "add -N" Yann Dirson
2009-08-28 19:05 ` Jeff King
2009-08-28 19:22 ` Jeff King
2009-08-29 22:34 ` Junio C Hamano
2009-08-30 9:55 ` Jeff King
2009-08-30 20:01 ` Junio C Hamano
2009-08-31 4:27 ` Jeff King
2009-08-31 5:03 ` Junio C Hamano
2009-08-31 5:05 ` Jeff King [this message]
2009-08-31 8:16 ` Yann Dirson
2009-08-31 4:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831050554.GA17197@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ydirson@linagora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).