From: Jeff King <peff@peff.net>
To: Sebastian Pipping <webmaster@hartwork.org>
Cc: Junio C Hamano <gitster@pobox.com>, Nicolas Pitre <nico@cam.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
Albert Astals Cid <aacid@kde.org>,
Pau Garcia i Quiles <pgquiles@elpauer.org>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] transport: don't show push status if --quiet is given
Date: Mon, 31 Aug 2009 15:28:34 -0400 [thread overview]
Message-ID: <20090831192834.GC4876@sigill.intra.peff.net> (raw)
In-Reply-To: <4A9C175E.6020905@hartwork.org>
On Mon, Aug 31, 2009 at 08:33:02PM +0200, Sebastian Pipping wrote:
> I run git push in a cron job, too. I want mails in error cases only
> so I need git push to print errors but _only_ errors to stderr. That
> seems impossible with 1.6.4.* and related to what you're discussing here.
>
> Does the patch you're building address that case already? has it been
> applied to any branch already? I got a bit lost in this thread, sorry.
Junio applied the series, and it is in 'master' right now (and so should
be part of the upcoming 1.6.5).
Using "git push -q" will do what you want, but playing with it a bit, I
think there is one bit missing from the original series:
-- >8 --
Subject: [PATCH] push: teach --quiet to suppress "Everything up-to-date"
This should have been part of 481c7a6, whose goal was to
make "git push -q" silent unless there is an error.
Signed-off-by: Jeff King <peff@peff.net>
---
transport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/transport.c b/transport.c
index ce91387..f2bd998 100644
--- a/transport.c
+++ b/transport.c
@@ -908,7 +908,7 @@ int transport_push(struct transport *transport,
update_tracking_ref(transport->remote, ref, verbose);
}
- if (!ret && !refs_pushed(remote_refs))
+ if (!quiet && !ret && !refs_pushed(remote_refs))
fprintf(stderr, "Everything up-to-date\n");
return ret;
}
--
1.6.4.2.372.gf7961.dirty
next prev parent reply other threads:[~2009-08-31 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 21:27 Making git push output quieter Albert Astals Cid
2009-08-04 22:20 ` Pau Garcia i Quiles
2009-08-05 19:13 ` Albert Astals Cid
2009-08-05 19:26 ` Shawn O. Pearce
2009-08-05 19:51 ` Nicolas Pitre
2009-08-05 20:19 ` Jeff King
2009-08-05 20:22 ` [RFC/PATCH 1/3] push: add --quiet flag Jeff King
2009-08-05 20:22 ` [PATCH 2/3] transport: pass "quiet" flag to pack-objects Jeff King
2009-08-05 20:23 ` [PATCH 3/3] transport: don't show push status if --quiet is given Jeff King
2009-08-05 20:27 ` Sverre Rabbelier
2009-08-05 20:29 ` Avery Pennarun
2009-08-05 20:30 ` Sverre Rabbelier
2009-08-05 20:39 ` Junio C Hamano
2009-08-05 20:48 ` Jeff King
2009-08-05 21:01 ` Junio C Hamano
2009-08-05 21:17 ` Jeff King
2009-08-31 18:33 ` Sebastian Pipping
2009-08-31 19:28 ` Jeff King [this message]
2009-08-31 19:39 ` Sebastian Pipping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831192834.GC4876@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aacid@kde.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=pgquiles@elpauer.org \
--cc=spearce@spearce.org \
--cc=webmaster@hartwork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).