From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: stash --dwim safety
Date: Tue, 1 Sep 2009 02:57:16 -0400 [thread overview]
Message-ID: <20090901065716.GA5575@sigill.intra.peff.net> (raw)
In-Reply-To: <vpqocpv2n93.fsf@bauges.imag.fr>
On Tue, Sep 01, 2009 at 08:27:20AM +0200, Matthieu Moy wrote:
> I was actually thinking of being a little more paranoid to prevent
> accidental "stash save": we could refuse to create a named stash when
> the "save" command is not given. The case I hadn't thought of was "git
> stash -q apply", which has 99% chances of being a typo for "git stash
> apply -q", and which would mean "create a stash named apply, quietly".
I like that. I think it addresses Dscho's concern with mistakes causing
an unexpected stash, and it is actually more consistent with the current
rule (that named stashes need an explicit 'save'). IOW, it is actually a
bit confusing that "git stash foo" doesn't work, but "git stash -k foo"
does.
-Peff
next prev parent reply other threads:[~2009-09-01 6:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 7:03 What's cooking in git.git (Aug 2009, #06; Sun, 30) Junio C Hamano
2009-08-31 9:32 ` Johan Herland
2009-09-01 5:58 ` stash --dwim safety (was Re: What's cooking in git.git (Aug 2009, #06; Sun, 30)) Junio C Hamano
2009-09-01 6:27 ` stash --dwim safety Matthieu Moy
2009-09-01 6:57 ` Jeff King [this message]
2009-09-02 4:11 ` Junio C Hamano
2009-09-02 4:59 ` Jeff King
2009-09-02 6:48 ` Johannes Schindelin
2009-09-02 6:26 ` Matthieu Moy
2009-09-01 15:08 ` What's cooking in git.git (Aug 2009, #06; Sun, 30) Peter Krefting
2009-09-01 16:47 ` Jakub Narebski
2009-09-01 16:51 ` Junio C Hamano
2009-09-02 17:44 ` Jakub Narebski
2009-09-02 18:16 ` Peter Harris
2009-09-01 22:25 ` Nick Edelen
2009-09-02 5:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901065716.GA5575@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).