From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org
Subject: Re: stash --dwim safety
Date: Wed, 2 Sep 2009 00:59:37 -0400 [thread overview]
Message-ID: <20090902045937.GA12046@coredump.intra.peff.net> (raw)
In-Reply-To: <7vy6oyj892.fsf@alter.siamese.dyndns.org>
[cc'ing Dscho, as he was the main opponent of similar proposals, and I
suspect his silence here means he missed this discussion. I hope this
addresses his concerns, but I think it is good to get comment from all
interested parties.
I'll just quote as appropriate below to comment, but for the whole patch
see:
http://article.gmane.org/gmane.comp.version-control.git/127574
]
On Tue, Sep 01, 2009 at 09:11:37PM -0700, Junio C Hamano wrote:
> This makes the logic of defaulting to "save" much simpler. If there is no
> non-flag arguments, it is clear that there is no command word, and we
s/is/are/ (or s/arguments/argument/)
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> [...]
> - --hard` to revert them. This is the default action when no
> - subcommand is given. The <message> part is optional and gives
> - the description along with the stashed state.
> + --hard` to revert them. The <message> part is optional and gives
> + the description along with the stashed state. For quickly making
> + a snapshot, you can omit _both_ "save" and <message>, but giving
> + only <message> does not trigger this action to prevent misspelled
> + subcommand from making an unwanted stash.
s/misspelled/a &/
-Peff
next prev parent reply other threads:[~2009-09-02 4:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 7:03 What's cooking in git.git (Aug 2009, #06; Sun, 30) Junio C Hamano
2009-08-31 9:32 ` Johan Herland
2009-09-01 5:58 ` stash --dwim safety (was Re: What's cooking in git.git (Aug 2009, #06; Sun, 30)) Junio C Hamano
2009-09-01 6:27 ` stash --dwim safety Matthieu Moy
2009-09-01 6:57 ` Jeff King
2009-09-02 4:11 ` Junio C Hamano
2009-09-02 4:59 ` Jeff King [this message]
2009-09-02 6:48 ` Johannes Schindelin
2009-09-02 6:26 ` Matthieu Moy
2009-09-01 15:08 ` What's cooking in git.git (Aug 2009, #06; Sun, 30) Peter Krefting
2009-09-01 16:47 ` Jakub Narebski
2009-09-01 16:51 ` Junio C Hamano
2009-09-02 17:44 ` Jakub Narebski
2009-09-02 18:16 ` Peter Harris
2009-09-01 22:25 ` Nick Edelen
2009-09-02 5:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902045937.GA12046@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).