From: Jeff King <peff@peff.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: "Sverre Rabbelier" <srabbelier@gmail.com>,
"Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Matthieu Moy" <Matthieu.Moy@imag.fr>,
"Sitaram Chamarty" <sitaramc@gmail.com>,
git@vger.kernel.org
Subject: Re: clong an empty repo over ssh causes (harmless) fatal
Date: Wed, 2 Sep 2009 01:16:15 -0400 [thread overview]
Message-ID: <20090902051615.GC12046@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LNX.2.00.0909020024270.28290@iabervon.org>
On Wed, Sep 02, 2009 at 12:33:52AM -0400, Daniel Barkalow wrote:
> > The patch below seems to work for me, but I'm a little concerned how it
> > might impact other transports.
>
> Does putting a "transport_disconnect(transport);" after the
> "transport_unlock_pack(transport);" in builtin-clone.c also work for you?
> I think that's a cleaner solution, and should future-proof it in case we
> have a future transport that both doesn't disconnect itself after a fetch
> and gives an error message if the connection is dropped suddenly.
>
> It's kind of just an accident that the only transport that cares about
> disconnect very much doesn't care if you've fetched after getting the
> refs.
It does work, and I think that is a much saner solution for the reasons
you mention. Thanks. Do you want to write it up and submit it, or should
I?
-Peff
next prev parent reply other threads:[~2009-09-02 5:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 11:14 clong an empty repo over ssh causes (harmless) fatal Sitaram Chamarty
2009-08-31 11:22 ` Matthieu Moy
2009-08-31 14:30 ` Sitaram Chamarty
2009-08-31 14:47 ` Matthieu Moy
2009-08-31 16:41 ` Jeff King
2009-08-31 17:12 ` Sverre Rabbelier
2009-08-31 19:08 ` Jeff King
2009-08-31 19:09 ` Sverre Rabbelier
2009-08-31 17:25 ` Matthieu Moy
2009-08-31 19:10 ` Jeff King
2009-08-31 20:19 ` Björn Steinbrink
2009-08-31 22:47 ` Jeff King
2009-08-31 22:50 ` Sverre Rabbelier
2009-09-01 1:08 ` Jeff King
2009-09-02 4:33 ` Daniel Barkalow
2009-09-02 5:16 ` Jeff King [this message]
2009-09-02 6:02 ` Daniel Barkalow
2009-09-02 6:36 ` [PATCH] clone: disconnect transport after fetching Jeff King
2009-09-02 7:09 ` Sverre Rabbelier
2009-09-02 7:26 ` Jeff King
2009-09-02 7:37 ` Sverre Rabbelier
2009-09-02 16:38 ` Daniel Barkalow
2009-09-02 17:55 ` Junio C Hamano
2009-09-04 2:30 ` Jeff King
2009-09-02 5:30 ` clong an empty repo over ssh causes (harmless) fatal Sitaram Chamarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902051615.GC12046@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=B.Steinbrink@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=sitaramc@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).