From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nasser Grainawi <nasser@codeaurora.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [JGIT] Request for help
Date: Thu, 3 Sep 2009 12:49:55 -0700 [thread overview]
Message-ID: <20090903194955.GL1033@spearce.org> (raw)
In-Reply-To: <4AA01D08.3060400@codeaurora.org>
Nasser Grainawi <nasser@codeaurora.org> wrote:
> Shawn O. Pearce wrote:
>> Hmm, maybe a method on Patch is reasonable.
>
> Going down this route, I'd add a few things to Patch.
> patchId would be a private field (of type ObjectId?)
> getPatchId would be a public method that returns patchId
> and then likely a private method (computePatchId?) that actually
> generates the patchId
Sure, but getPatchId can compute it on demand on the first call,
and anyone who modifies the Patch would just need to clear out
the cached patchId value so the next call (if it ever comes) to
getPatchId would force it to recompute.
Most users of Patch won't want the patchId, so there is no reason
to compute it.
--
Shawn.
next prev parent reply other threads:[~2009-09-03 19:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 23:28 [JGIT] Request for help Nasser Grainawi
2009-09-03 0:04 ` Johannes Schindelin
2009-09-03 1:22 ` Shawn O. Pearce
2009-09-03 6:55 ` jgit diff, was " Johannes Schindelin
2009-09-03 10:45 ` [JGIT PATCH 0/5] jgit diff Johannes Schindelin
2009-09-03 10:46 ` [JGIT PATCH 1/5] Add set to IntList Johannes Schindelin
2009-09-03 10:46 ` [JGIT PATCH 2/5] Add Myers' algorithm to generate diff scripts Johannes Schindelin
2009-09-03 10:46 ` [JGIT PATCH 3/5] Add a test class for Myers' diff algorithm Johannes Schindelin
2009-09-03 10:47 ` [JGIT PATCH 4/5] Prepare RawText for diff-index and diff-files Johannes Schindelin
2009-09-03 10:47 ` [JGIT PATCH 5/5] Add the "jgit diff" command Johannes Schindelin
2009-09-03 10:48 ` [JGIT PATCH 0/5] jgit diff Johannes Schindelin
2009-10-01 18:47 ` Shawn O. Pearce
2009-10-01 21:47 ` Johannes Schindelin
2009-09-03 15:54 ` jgit diff, was Re: [JGIT] Request for help Christian Halstrick
2009-09-03 12:45 ` Jonas Fonseca
2009-09-03 14:42 ` Shawn O. Pearce
2009-09-03 15:38 ` Jonas Fonseca
2009-09-03 15:52 ` Shawn O. Pearce
2009-09-04 5:00 ` Gabe McArthur
2009-09-04 7:33 ` Mark Struberg
2009-09-04 12:22 ` Jonas Fonseca
2009-09-04 12:27 ` Mark Struberg
2009-09-04 12:41 ` Jonas Fonseca
2009-09-04 12:47 ` Mark Struberg
2009-09-03 1:23 ` Shawn O. Pearce
2009-09-03 19:46 ` Nasser Grainawi
2009-09-03 19:49 ` Shawn O. Pearce [this message]
2009-09-03 21:09 ` Nasser Grainawi
-- strict thread matches above, loose matches on Subject: below --
2009-09-04 7:12 Mark Struberg
[not found] <ed88cb980909040744k2fa372fapb7ee457c745b9aa0@mail.gmail.com>
2009-09-04 14:49 ` Mark Struberg
2009-09-04 17:28 ` Mark Struberg
2009-09-04 18:50 ` Jonas Fonseca
2009-09-04 18:54 ` Mark Struberg
2009-09-04 19:51 ` Mark Struberg
2009-09-04 23:47 ` Gabe
2009-09-05 0:06 ` Douglas Campos
2009-09-05 1:29 ` Gabe McArthur
2009-09-05 16:25 ` Robin Rosenberg
2009-09-05 16:40 ` Mark Struberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903194955.GL1033@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=nasser@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).