From: Lars Noschinski <lars@public.noschinski.de>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH] post-receive-email: do not call sendmail if no mail was generated
Date: Tue, 8 Sep 2009 11:20:59 +0200 [thread overview]
Message-ID: <20090908092059.GA8207@lars.home.noschinski.de> (raw)
In-Reply-To: <1251481187-6361-1-git-send-email-lars@public.noschinski.de>
* Lars Noschinski <lars@public.noschinski.de> [09-08-28 19:39]:
> contrib/hooks/post-receive-email used to call the send_mail function
> (and thus, /usr/sbin/sendmail), even if generate_mail returned an error.
> This is problematic, as the sendmail binary provided by exim4 generates
> an error mail if provided with an empty input.
>
> Therefore, this commit changes post-receive-email to only call sendmail
> if generate_mail returned without error.
>
> Signed-off-by: Lars Noschinski <lars@public.noschinski.de>
Is anything wrong with this patch? Or is it just queued to be committed
some time?
- Lars.
next prev parent reply other threads:[~2009-09-08 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 17:39 [PATCH] post-receive-email: do not call sendmail if no mail was generated Lars Noschinski
2009-09-08 9:20 ` Lars Noschinski [this message]
2009-09-08 16:57 ` Junio C Hamano
2009-09-08 18:55 ` Lars Noschinski
2009-09-08 19:00 ` Lars Noschinski
2009-09-08 20:15 ` Junio C Hamano
2009-09-08 20:59 ` Lars Noschinski
2009-09-08 21:49 ` Junio C Hamano
2009-09-08 21:12 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908092059.GA8207@lars.home.noschinski.de \
--to=lars@public.noschinski.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).