From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
Nanako Shiraishi <nanako3@lavabit.com>,
git@vger.kernel.org
Subject: [PATCH v2] Re: add documentation for mailinfo.scissors and '--no-scissors'
Date: Fri, 11 Sep 2009 15:41:12 +0200 [thread overview]
Message-ID: <20090911134112.GA18684@vidovic> (raw)
In-Reply-To: <7veiqe0x05.fsf@alter.siamese.dyndns.org>
[ Thank you for this review. ]
The 11/09/09, Junio C Hamano wrote:
> Nicolas Sebrecht <nicolas.s.dev@gmx.fr> writes:
>
> > diff --git a/git-am.sh b/git-am.sh
> > index 26ffe70..f242d1a 100755
> > --- a/git-am.sh
> > +++ b/git-am.sh
> > @@ -16,6 +16,7 @@ s,signoff add a Signed-off-by line to the commit message
> > u,utf8 recode into utf8 (default)
> > k,keep pass -k flag to git-mailinfo
> > c,scissors strip everything before a scissors line
> > +no-scissors don't obey to a scissors line (default)
> > whitespace= pass it through git-apply
> > ignore-space-change pass it through git-apply
> > ignore-whitespace pass it through git-apply
>
> Do we want it to allow --no-no-scissors? I do not think this hunk is
> necessary at all.
I don't understand your point here. This hunk doesn't allow
--no-no-scissors but add --no-scissors to usage of 'git am', no?
Do I miss something around $OPTIONS_SPEC?
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-09-11 13:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 0:56 What's cooking in git.git (Sep 2009, #02; Mon, 07) Junio C Hamano
2009-09-08 6:31 ` Nanako Shiraishi
2009-09-08 6:48 ` Junio C Hamano
2009-09-08 13:10 ` Jakub Narebski
2009-09-08 13:17 ` Sverre Rabbelier
2009-09-09 11:59 ` jk/1.7.0-status, was: " Jeff King
2009-09-10 16:18 ` Daniel Barkalow
2009-09-10 16:53 ` Johannes Schindelin
2009-09-10 17:55 ` Daniel Barkalow
2009-09-10 18:41 ` Junio C Hamano
2009-09-11 0:09 ` scissors definition and documentation Nicolas Sebrecht
2009-09-11 0:09 ` [PATCH 1/2] mailinfo: add '--scissors' to usage message Nicolas Sebrecht
2009-09-11 0:09 ` [PATCH 2/2] add documentation for mailinfo.scissors and '--no-scissors' Nicolas Sebrecht
2009-09-11 0:29 ` [PATCH v2] " Nicolas Sebrecht
2009-09-11 7:19 ` Junio C Hamano
2009-09-11 13:41 ` Nicolas Sebrecht [this message]
2009-09-11 18:53 ` [PATCH v2] " Junio C Hamano
2009-09-11 20:08 ` Nicolas Sebrecht
2009-09-11 21:00 ` Junio C Hamano
2009-09-12 3:03 ` Nicolas Sebrecht
[not found] ` <682ef47420f36d8c53e42981370d377b621d7b86.1252698215.git.nicolas.s.dev@gmx.fr>
2009-09-11 19:50 ` [PATCH v3 2/2] " Nicolas Sebrecht
2009-09-12 0:33 ` What's cooking in git.git (Sep 2009, #02; Mon, 07) Junio C Hamano
2009-09-12 4:38 ` Junio C Hamano
2009-09-12 11:46 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911134112.GA18684@vidovic \
--to=nicolas.s.dev@gmx.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).