From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: msysgit@googlegroups.com, Alexey Borzenkov <snaury@gmail.com>,
git@vger.kernel.org
Subject: [PATCH 2/2] pager: set LESS=FRSX also on Windows
Date: Fri, 11 Sep 2009 19:45:07 +0200 [thread overview]
Message-ID: <200909111945.07842.j6t@kdbg.org> (raw)
In-Reply-To: <200909111940.08652.j6t@kdbg.org>
Previously, this environment variable was set in the pager_preexec
callback, which is conditionally-compiled only on Unix, because it is not,
and cannot be, called on Windows.
With this patch the env member of struct child_process is used to set
the environment variable, which also works on Windows.
Noticed by Alexey Borzenkov.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
Alexey,
this will result in a conflict when you apply it to your msysgit because
there is an extra patch that shuffled the setup of pager_process around.
-- Hannes
| 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
--git a/pager.c b/pager.c
index 4921843..f416d38 100644
--- a/pager.c
+++ b/pager.c
@@ -21,8 +21,6 @@ static void pager_preexec(void)
FD_ZERO(&in);
FD_SET(0, &in);
select(1, &in, NULL, &in, NULL);
-
- setenv("LESS", "FRSX", 0);
}
#endif
@@ -70,6 +68,10 @@ void setup_pager(void)
pager_argv[2] = pager;
pager_process.argv = pager_argv;
pager_process.in = -1;
+ if (!getenv("LESS")) {
+ static const char *env[] = { "LESS=FRSX", NULL };
+ pager_process.env = env;
+ }
#ifndef __MINGW32__
pager_process.preexec_cb = pager_preexec;
#endif
--
1.6.5.rc0.28.gfb9b
next prev parent reply other threads:[~2009-09-11 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909092337.39885.j6t@kdbg.org>
[not found] ` <1252560077-1725-1-git-send-email-snaury@gmail.com>
2009-09-11 17:40 ` [PATCH 1/2] start_command: do not clobber cmd->env on Windows code path Johannes Sixt
2009-09-11 17:45 ` Johannes Sixt [this message]
2009-09-12 4:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909111945.07842.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=snaury@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).