* [PATCH 2/2] Re: Makefile: remove unused CURL_SYNONYMS variable
[not found] ` <7vd45wloj4.fsf@alter.siamese.dyndns.org>
@ 2009-09-12 5:52 ` Nicolas Sebrecht
0 siblings, 0 replies; only message in thread
From: Nicolas Sebrecht @ 2009-09-12 5:52 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Nicolas Sebrecht, Daniel Barkalow, Mike Ralphson, git
The 11/09/09, Junio C Hamano wrote:
>
> This looks wrong. What's filtering out of what?
>
> I think you meant to finish the revert of ad17f01 (Makefile: install
> hardlinks for git-remote-<scheme> supported by libcurl if possible,
> 2009-08-07) that c9e388b (Make the "traditionally-supported" URLs a
> special case, 2009-09-03) attempted to do but missed.
>
> Perhaps you meant to do this?
>
> diff --git a/Makefile b/Makefile
> index 8c44e35..1ac02d1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1655,7 +1655,7 @@ export gitexec_instdir
> install: all
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
> - $(INSTALL) $(filter-out $(CURL_SYNONYMS), $(ALL_PROGRAMS)) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
> + $(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
> $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)'
> $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
> ifndef NO_PERL
Yes, exactly. Sorry for the mistake.
Oh, and I just saw that my sendemail.cc configuration has been ignored
resulting in not cc'ing the mailing list (fixed for this mail). I guess
it comes from some --cc options added at command line. Shouldn't --cc
add new cc to the cc list instead of override sendemail.cc?
--
Nicolas Sebrecht
^ permalink raw reply [flat|nested] only message in thread