From: Todd Zullinger <tmz@pobox.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Jeff King <peff@peff.net>, james bardin <jbardin@bu.edu>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] completion: Replace config --list with --get-regexp
Date: Sun, 13 Sep 2009 14:29:37 -0400 [thread overview]
Message-ID: <20090913182937.GR2582@inocybe.localdomain> (raw)
In-Reply-To: <36ca99e90909130351m7ad5a641t8adb3ade3d2ec5ca@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Bert Wesarg wrote:
> I have not looked into this, but what about pushurl?
Is it reasonable to expect someone to have remote.<name>.pushurl and
not have remote.<name>.url set? If not, then we should be fine, as
all the old code and this new code do is extract <name>.
OTOH, if there are some cases where setting pushurl and not url make
sense, extending the regex to catch pushurl as well is a simple matter
of changing 'remote\..*\.url' to 'remote\..*\.(push)?url' and, I
believe, using 'echo "${i/.*url*/}"' to strip off everything after the
remote <name>.
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fleas can be taught nearly anything that a Congressman can.
-- Mark Twain
[-- Attachment #2: Type: application/pgp-signature, Size: 542 bytes --]
next prev parent reply other threads:[~2009-09-13 18:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 15:13 bash_completion outside repo james bardin
2009-09-11 13:11 ` Michael J Gruber
2009-09-11 13:33 ` Todd Zullinger
2009-09-11 14:00 ` james bardin
2009-09-11 14:17 ` Jeff King
2009-09-11 14:36 ` Shawn O. Pearce
2009-09-11 15:09 ` Jeff King
2009-09-11 16:47 ` Jeff King
2009-09-11 20:43 ` Junio C Hamano
2009-09-11 21:12 ` Jeff King
2009-09-11 21:22 ` Junio C Hamano
2009-09-11 21:29 ` Jeff King
2009-09-11 21:57 ` Junio C Hamano
2009-09-11 22:04 ` Junio C Hamano
2009-09-11 22:05 ` Jeff King
2009-09-11 23:23 ` [PATCH] completion: Replace config --list with --get-regexp Todd Zullinger
2009-09-12 18:31 ` Shawn O. Pearce
2009-09-13 10:51 ` Bert Wesarg
2009-09-13 18:29 ` Todd Zullinger [this message]
2009-09-13 20:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913182937.GR2582@inocybe.localdomain \
--to=tmz@pobox.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jbardin@bu.edu \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox