From: Jeff King <peff@peff.net>
To: Jim Meyering <jim@meyering.net>
Cc: Alex Riesen <raa.lkml@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] pre-commit.sample: don't use [...] around a tr range
Date: Mon, 21 Sep 2009 09:44:27 -0400 [thread overview]
Message-ID: <20090921134427.GA20567@sigio.peff.net> (raw)
In-Reply-To: <87ocp4imul.fsf@meyering.net>
On Mon, Sep 21, 2009 at 01:00:34PM +0200, Jim Meyering wrote:
> > We have (had?) people trying to support Git on HP-UX and SunOS.
> > Do these count?
>
> I had my doubts, but have just confirmed that Solaris 10's
> /usr/bin/tr is still doing it the SYSV way:
>
> $ echo foo | LC_ALL=C /usr/bin/tr a-z A-Z
> foo
>
> There, you have to use /usr/xpg4/bin/tr to get the expected behavior:
>
> $ echo foo | LC_ALL=C /usr/xpg4/bin/tr a-z A-Z
> FOO
>
> So you're right. Thanks!
See:
http://article.gmane.org/gmane.comp.version-control.git/76991
> + # Note that the use of brackets around a tr range is ok here, (it's
> + # even required, for portability to Solaris 10's /usr/bin/tr), since
> + # the square bracket bytes happen to fall in the designated range.
> test "$(git diff --cached --name-only --diff-filter=A -z |
> LC_ALL=C tr -d '[ -~]\0')"
Does this work on non-bracket systems? I would think that enumerating
the sequence would be the most portable thing.
-Peff
next prev parent reply other threads:[~2009-09-21 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 9:09 [PATCH] pre-commit.sample: don't use [...] around a tr range Jim Meyering
2009-09-21 9:43 ` Alex Riesen
2009-09-21 11:00 ` Jim Meyering
2009-09-21 12:45 ` Alex Riesen
2009-09-21 13:44 ` Jeff King [this message]
2009-09-21 14:10 ` Jim Meyering
2009-09-21 14:21 ` Jeff King
2009-09-21 15:58 ` Brandon Casey
2009-09-24 5:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090921134427.GA20567@sigio.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox