From: "Shawn O. Pearce" <spearce@spearce.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: git@vger.kernel.org, mstormo@gmail.com
Subject: Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer
Date: Fri, 25 Sep 2009 15:05:10 -0700 [thread overview]
Message-ID: <20090925220510.GY14660@spearce.org> (raw)
In-Reply-To: <4ABB84F4.7080403@gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> wrote:
> From c6d29a2d243647bb2877eb2114938ae20c8e56e5 Mon Sep 17 00:00:00 2001
> From: Sebastian Schuberth <sschuberth@gmail.com>
> Date: Thu, 24 Sep 2009 15:52:25 +0200
> Subject: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer
>
> In order to be able to open the generated solution file by double-clicking it
> in Windows Explorer, all project files need to use DOS line-endings and a
> comment about the Visual Studio version needs to be added to the header of the
> solution file. This also fixes the icon that is displayed for the solution file
> in Windows Explorer.
> Note that opening the solution file from a running instance of Visual Studio
> already worked before.
Something is wrong with both patches; neither applies. It looks
to be an issue with whitespace, like context lines are gaining an
extra space at the start of the line.
--
Shawn.
next prev parent reply other threads:[~2009-09-25 22:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 14:40 [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Sebastian Schuberth
2009-09-25 22:05 ` Shawn O. Pearce [this message]
2009-09-25 22:11 ` Alex Riesen
2009-09-25 22:45 ` Sebastian Schuberth
2009-09-25 22:41 ` Sebastian Schuberth
2009-09-25 22:59 ` Shawn O. Pearce
2009-09-25 23:58 ` Sebastian Schuberth
2009-09-26 0:05 ` Shawn O. Pearce
2009-09-26 9:45 ` Sebastian Schuberth
2009-09-26 20:05 ` Shawn O. Pearce
2009-09-28 10:36 ` Baz
2009-09-28 13:40 ` Sebastian Schuberth
2009-09-28 11:34 ` [PATCH 0/2] MSVC generator fixups Marius Storm-Olsen
2009-09-28 13:01 ` Sebastian Schuberth
2009-09-28 11:34 ` [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Marius Storm-Olsen
2009-09-28 11:34 ` [PATCH 2/2] Make just opening the generated MSVC solution file not modify it Marius Storm-Olsen
-- strict thread matches above, loose matches on Subject: below --
2009-09-24 14:40 [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925220510.GY14660@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=mstormo@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).