From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Halstrick, Christian" <christian.halstrick@sap.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [JGIT PATCH 1/2] add support for core.logAllRefUpdates configuration parameter
Date: Sat, 26 Sep 2009 00:52:39 +0200 [thread overview]
Message-ID: <200909260052.39469.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <200909260045.21171.robin.rosenberg@dewire.com>
lördag 26 september 2009 00:45:20 skrev Robin Rosenberg <robin.rosenberg@dewire.com>:
> onsdag 23 september 2009 18:42:29 skrev "Halstrick, Christian" <christian.halstrick@sap.com>:
> > From: Christian Halstrick <christian.halstrick@sap.com>
> >
> > JGit should understand configuration parameter logAllRefUpdates and should
> > only log updates of refs when
> > either the log file for this ref is already present
> > or this configuration parameter is set to true
> > Before this commit JGit was always writing logs, regardless of this
> > parameter or existence of logfiles.
>
> A few minor things:
Forgot: Please:
> Format the comment nicely and space betwee paragraphs.
[...]
-- robin
prev parent reply other threads:[~2009-09-25 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 16:42 [JGIT PATCH 1/2] add support for core.logAllRefUpdates configuration parameter Halstrick, Christian
2009-09-25 22:45 ` Robin Rosenberg
2009-09-25 22:52 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909260052.39469.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=christian.halstrick@sap.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).