git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: git@vger.kernel.org, mstormo@gmail.com
Subject: Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer
Date: Sat, 26 Sep 2009 13:05:29 -0700	[thread overview]
Message-ID: <20090926200529.GJ14660@spearce.org> (raw)
In-Reply-To: <bdca99240909260245i6ba10dd4j1b2ee9e74ea5282d@mail.gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> wrote:
> On Sat, Sep 26, 2009 at 02:05, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Odd. ??If I copy and paste from Thunderbird, its fine. ??But if I
> > save the body out as an attachment from mutt, it fails.
> >
> > I wonder if it has to do with the From header appearing in the top
> > of the body; this header has to be escaped with a leading space in
> > mbox format. ??It looks like Thunderbird might be doing some magic to
> > remove that leading space from the context lines, while mutt isn't.
> >
> > Next time, don't include the first From line?
> 
> Will try. So what about these two patches? Should I re-send them with
> the first "From" stripped?

Might be worth trying.  I honestly don't know why they were munged
before.
 
> Or will *.patch files that are attached to emails, instead of sending
> the patch inline, be accepted?

We really don't like them, because you can't comment on them inline
easily.  Sometimes they are acceptable for translation files when
the character encoding otherwise gets really broken.

-- 
Shawn.

  reply	other threads:[~2009-09-26 20:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 14:40 [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Sebastian Schuberth
2009-09-25 22:05 ` Shawn O. Pearce
2009-09-25 22:11   ` Alex Riesen
2009-09-25 22:45     ` Sebastian Schuberth
2009-09-25 22:41   ` Sebastian Schuberth
2009-09-25 22:59     ` Shawn O. Pearce
2009-09-25 23:58       ` Sebastian Schuberth
2009-09-26  0:05         ` Shawn O. Pearce
2009-09-26  9:45           ` Sebastian Schuberth
2009-09-26 20:05             ` Shawn O. Pearce [this message]
2009-09-28 10:36             ` Baz
2009-09-28 13:40               ` Sebastian Schuberth
2009-09-28 11:34 ` [PATCH 0/2] MSVC generator fixups Marius Storm-Olsen
2009-09-28 13:01   ` Sebastian Schuberth
2009-09-28 11:34 ` [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Marius Storm-Olsen
2009-09-28 11:34 ` [PATCH 2/2] Make just opening the generated MSVC solution file not modify it Marius Storm-Olsen
  -- strict thread matches above, loose matches on Subject: below --
2009-09-24 14:40 [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Sebastian Schuberth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090926200529.GJ14660@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=mstormo@gmail.com \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).