From: Miklos Vajna <vmiklos@frugalware.org>
To: Jeff King <peff@peff.net>
Cc: Matthieu.Moy@grenoble-inp.fr, spearce@spearce.org, git@vger.kernel.org
Subject: Re: [PATCH] git branch -D: give a better error message when lockfile creation fails
Date: Sun, 27 Sep 2009 10:49:06 +0200 [thread overview]
Message-ID: <20090927084906.GR32702@genesis.frugalware.org> (raw)
In-Reply-To: <20090927082123.GD15393@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
On Sun, Sep 27, 2009 at 04:21:23AM -0400, Jeff King <peff@peff.net> wrote:
> Maybe it is just me, but that extra die() that should never be reached
> is terribly ugly. I would do it with two functions, one that dies and
> one that doesn't, with a helper to format the message. IOW, this:
Okay, that's fine with me - thanks for providing a patch as well.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-09-27 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 0:06 [PATCH] git branch -D: give a better error message when lockfile creation fails Miklos Vajna
2009-09-26 3:31 ` Jeff King
2009-09-26 13:34 ` Miklos Vajna
2009-09-26 19:58 ` Shawn O. Pearce
2009-09-26 20:04 ` Matthieu Moy
2009-09-26 23:15 ` Miklos Vajna
2009-09-27 8:21 ` Jeff King
2009-09-27 8:49 ` Miklos Vajna [this message]
2009-09-26 20:12 ` Matthieu Moy
-- strict thread matches above, loose matches on Subject: below --
2009-09-25 23:53 Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090927084906.GR32702@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).