From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@googlemail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org, msysgit@googlegroups.com, gitster@pobox.com,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH 2/2] add NORETURN_PTR for function pointers
Date: Thu, 1 Oct 2009 04:17:10 -0400 [thread overview]
Message-ID: <20091001081710.GC13436@coredump.intra.peff.net> (raw)
In-Reply-To: <1254333950-2440-2-git-send-email-kusmabite@gmail.com>
On Wed, Sep 30, 2009 at 06:05:50PM +0000, Erik Faye-Lund wrote:
> Some compilers (including at least MSVC and ARM RVDS) supports
> NORETURN on function declarations, but not on function pointers.
>
> This patch makes it possible to define NORETURN for these compilers,
> by splitting the NORETURN macro into two - one for function
> declarations and one for function pointers.
Thanks, this version and (your 1/2) both look sane to me. The only thing
missing are some Makefile knobs to tweak this, but I will assume that
will come as part of a later MSVC-compatibility series.
Shawn, this can go straight to 'next', if not 'master'. The changes
should be a no-op for most platforms. The only danger would be if there
is some platform that doesn't like their NORETURN magic at the front of
the function declaration. But we only define it by default for __GNUC__,
so I suspect we're safe.
In my tree as ef/msvc-noreturn.
-Peff
next prev parent reply other threads:[~2009-10-01 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 18:05 [PATCH 1/2] increase portability of NORETURN declarations Erik Faye-Lund
2009-09-30 18:05 ` [PATCH 2/2] add NORETURN_PTR for function pointers Erik Faye-Lund
2009-10-01 8:17 ` Jeff King [this message]
2009-10-01 16:57 ` Erik Faye-Lund
2009-10-02 0:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001081710.GC13436@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=kusmabite@googlemail.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).