From: Clemens Buchacher <drizzd@aon.at>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: [PATCH 2/2] allow mangling short options which take integer arguments
Date: Thu, 1 Oct 2009 22:23:01 +0200 [thread overview]
Message-ID: <20091001202301.GB12175@localhost> (raw)
In-Reply-To: <20091001201648.GA12175@localhost>
This patch allows you to do things like for example
$ git <cmd> -bn100
where -b is a boolean and -n is an integer option.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
parse-options.c | 2 +-
parse-options.h | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/parse-options.c b/parse-options.c
index 4f16f37..bfe01ee 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -48,7 +48,7 @@ static int get_value(struct parse_opt_ctx_t *p,
const int unset = flags & OPT_UNSET;
int err;
- if (many && !(opt->flags & PARSE_OPT_NOARG))
+ if (many && !(opt->flags & (PARSE_OPT_NOARG | PARSE_OPT_MANY)))
return opterror(opt, "must not be mangled with other options", flags);
if (unset && p->opt)
return opterror(opt, "takes no value", flags);
diff --git a/parse-options.h b/parse-options.h
index f295a2c..33ce529 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -37,6 +37,7 @@ enum parse_opt_option_flags {
PARSE_OPT_NODASH = 32,
PARSE_OPT_LITERAL_ARGHELP = 64,
PARSE_OPT_NEGHELP = 128,
+ PARSE_OPT_MANY = 256,
};
struct option;
@@ -84,6 +85,8 @@ typedef int parse_opt_cb(const struct option *, const char *arg, int unset);
* PARSE_OPT_NEGHELP: says that the long option should always be shown with
* the --no prefix in the usage message. Sometimes
* useful for users of OPTION_NEGBIT.
+ * PARSE_OPT_MANY: the short option may be mangled, despite a possible
+ * argument.
*
* `callback`::
* pointer to the callback to use for OPTION_CALLBACK.
@@ -121,7 +124,7 @@ struct option {
(h), PARSE_OPT_NOARG, NULL, (i) }
#define OPT_SET_PTR(s, l, v, h, p) { OPTION_SET_PTR, (s), (l), (v), NULL, \
(h), PARSE_OPT_NOARG, NULL, (p) }
-#define OPT_INTEGER(s, l, v, h) { OPTION_INTEGER, (s), (l), (v), "n", (h) }
+#define OPT_INTEGER(s, l, v, h) { OPTION_INTEGER, (s), (l), (v), "n", (h), PARSE_OPT_MANY }
#define OPT_STRING(s, l, v, a, h) { OPTION_STRING, (s), (l), (v), (a), (h) }
#define OPT_DATE(s, l, v, h) \
{ OPTION_CALLBACK, (s), (l), (v), "time",(h), 0, \
--
1.6.5.rc1.214.g13c5a
next prev parent reply other threads:[~2009-10-01 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 23:32 how optparse can go horribly wrong Shawn O. Pearce
2009-09-26 1:51 ` Nicolas Sebrecht
2009-09-26 13:44 ` Sverre Rabbelier
2009-09-26 19:25 ` Shawn O. Pearce
2009-09-28 13:37 ` Clemens Buchacher
2009-10-01 20:16 ` [PATCH 1/2] do not mangle short options which take arguments Clemens Buchacher
2009-10-01 20:23 ` Clemens Buchacher [this message]
2009-10-01 21:55 ` [PATCH 2/2] allow mangling short options which take integer arguments Johannes Schindelin
2009-10-02 7:43 ` Clemens Buchacher
2009-10-02 7:50 ` Jeff King
2009-10-02 8:26 ` Clemens Buchacher
2009-10-02 8:41 ` Johannes Schindelin
2009-10-03 9:23 ` Clemens Buchacher
2009-10-01 21:53 ` [PATCH 1/2] do not mangle short options which take arguments Johannes Schindelin
2009-10-02 6:11 ` Jeff King
2009-10-02 7:36 ` Clemens Buchacher
2009-10-02 7:46 ` Paolo Bonzini
2009-10-02 7:57 ` Jeff King
2009-10-02 8:42 ` Johannes Schindelin
2009-10-02 8:43 ` Jeff King
2009-10-02 9:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001202301.GB12175@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).