From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@googlemail.com>
Cc: msysgit@googlegroups.com, git@vger.kernel.org
Subject: Re: [PATCH/RFC 1/7] imap-send: use separate read and write fds
Date: Sat, 3 Oct 2009 16:34:48 -0400 [thread overview]
Message-ID: <20091003203448.GA9058@sigill.intra.peff.net> (raw)
In-Reply-To: <40aa078e0910031144r735a6fdq25efc1e57a1d4c33@mail.gmail.com>
On Sat, Oct 03, 2009 at 11:44:50AM -0700, Erik Faye-Lund wrote:
> Yeah, this is about Windows portability.
>
> I'll add something like "This is a patch that enables us to use the
> run-command API, which is supported on Windows." to the commit-message
> in the next round. Is that enough?
Yeah, that would be fine. I was just left scratching my head wondering
what subtle portability difference the two descriptors could have. But
if it really is just a cleanup for the next patch, that's OK; just say
so.
-Peff
next prev parent reply other threads:[~2009-10-03 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 0:39 [PATCH/RFC 1/7] imap-send: use separate read and write fds Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 2/7] imap-send: use run-command API for tunneling Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 3/7] imap-send: fix compilation-error on Windows Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 4/7] imap-send: build imap-send " Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 5/7] imap-send: provide fall-back random-source Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 6/7] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 7/7] mingw: enable OpenSSL Erik Faye-Lund
2009-10-03 9:58 ` [PATCH/RFC 5/7] imap-send: provide fall-back random-source Jeff King
2009-10-03 18:45 ` Erik Faye-Lund
2009-10-03 18:59 ` Erik Faye-Lund
2009-10-03 20:43 ` Jeff King
2009-10-03 20:52 ` Jeff King
2009-10-08 23:16 ` Erik Faye-Lund
2009-10-09 0:03 ` Jeff King
2009-10-03 9:40 ` [PATCH/RFC 1/7] imap-send: use separate read and write fds Jeff King
2009-10-03 18:44 ` Erik Faye-Lund
2009-10-03 20:34 ` Jeff King [this message]
2009-10-03 21:34 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091003203448.GA9058@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@googlemail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).