From: "Shawn O. Pearce" <spearce@spearce.org>
To: Herv?? Cauwelier <herve@itaapy.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/6] Open the pack file and keep a map on it.
Date: Mon, 5 Oct 2009 08:27:55 -0700 [thread overview]
Message-ID: <20091005152755.GF9261@spearce.org> (raw)
In-Reply-To: <1254593401-18801-2-git-send-email-herve@itaapy.com>
Herv?? Cauwelier <herve@itaapy.com> wrote:
> diff --git a/src/odb.h b/src/odb.h
> index 2f205b2..0311d78 100644
> --- a/src/odb.h
> +++ b/src/odb.h
> @@ -11,9 +11,10 @@
> * uint32_t *fanout = ... the file data at offset 0 ...
> * ntohl(fanout[0]) < ntohl(fanout[1])
> *
> - * The value chosen here for PACK_TOC is such that the above
> + * The value chosen here for IDX_TOC is such that the above
> * cannot be true for an idx v1 file.
> */
> -#define PACK_TOC 0xff744f63 /* -1tOc */
> +#define IDX_TOC 0xff744f63 /* -1tOc */
> +#define PACK_TOC 0x5041434b /* PACK */
FWIW, I wouldn't call the magic string 'PACK' PACK_TOC. TOC here
meant "table of contents". The magic string '-1tOc' for PACK_TOC
is no accident, its trying to show that this file is a table of
contents file.
I think at the time I meant for PACK_TOC to be the pack-*.idx
header magic string, and PACK_SIG or PACK_HDR to be the magic
string for pack-*.pack.
--
Shawn.
next prev parent reply other threads:[~2009-10-05 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 18:09 Patches for libgit2 Hervé Cauwelier
2009-10-03 18:09 ` [PATCH 1/6] Open the pack file and keep a map on it Hervé Cauwelier
2009-10-03 18:09 ` [PATCH 2/6] Read the base offset or name of delta objects Hervé Cauwelier
2009-10-03 18:09 ` [PATCH 3/6] Allow zlib to read a pack buffer longer than the actual data Hervé Cauwelier
2009-10-03 18:09 ` [PATCH 4/6] Inflate an object from a pack file Hervé Cauwelier
2009-10-03 18:10 ` [PATCH 5/6] This assertion is valid for both loose and packed objects Hervé Cauwelier
2009-10-03 18:10 ` [PATCH 6/6] Read an object from a pack file Hervé Cauwelier
2009-10-05 15:27 ` Shawn O. Pearce [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-14 10:37 [PATCH 1/6] Open the pack file and keep a map on it Hervé Cauwelier
2009-10-14 12:48 ` Sverre Rabbelier
2009-10-14 15:29 ` Hervé Cauwelier
2009-10-14 15:30 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005152755.GF9261@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=herve@itaapy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).