From: Jeff King <peff@peff.net>
To: Petter Urkedal <urkedal@nbi.dk>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Stephen Boyd <bebarino@gmail.com>
Subject: Re: [PATCH] Reserve a slot for argv[0] in default_arg.
Date: Mon, 5 Oct 2009 14:45:32 -0400 [thread overview]
Message-ID: <20091005184532.GA20078@coredump.intra.peff.net> (raw)
In-Reply-To: <20091005063649.GA25040@eideticdew.org>
On Mon, Oct 05, 2009 at 08:36:49AM +0200, Petter Urkedal wrote:
> On 2009-10-04, Junio C Hamano wrote:
> > It is a command specific aliasing mechanism; not even I use the feature
> > these days, since "alias.*" is much easier to use. But there is no strong
> > need to remove it either; it is not too much hassle to keep it for people
> > who do use it. Perhaps deprecate it and remove it in the long run?
>
> I didn't know about alias.*. Excellent. I'll be using that.
Yeah, showbranch.default really seems pointless now. Especially
confusing is the fact that it doesn't do whitespace-splitting, so you
can't do:
git config showbranch.default "--topo-order branch1 branch2"
but instead have to set multiple config variables.
I think deprecation makes sense, but I am in no hurry to get rid of it.
I mainly just wouldn't want people to think it was a useful thing to
learn. :)
> The code is slightly nicer to, I think, but you can probably drop "+ 20"
> in the grow-case now.
I think it could actually just be switched to use ALLOC_GROW.
-Peff
next prev parent reply other threads:[~2009-10-05 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 13:29 [PATCH] Reserve a slot for argv[0] in default_arg Petter Urkedal
2009-10-04 13:33 ` Jeff King
2009-10-04 14:13 ` Petter Urkedal
2009-10-04 18:27 ` Jeff King
2009-10-04 20:02 ` Stephen Boyd
2009-10-04 22:20 ` Junio C Hamano
2009-10-05 6:36 ` Petter Urkedal
2009-10-05 18:45 ` Jeff King [this message]
2009-10-05 6:44 ` Petter Urkedal
2009-10-04 14:51 ` Petter Urkedal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005184532.GA20078@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=urkedal@nbi.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).