From: "Shawn O. Pearce" <spearce@spearce.org>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH] The default encoding for reading commits is UTF-8 rather than system default
Date: Wed, 7 Oct 2009 21:16:10 -0700 [thread overview]
Message-ID: <20091008041609.GV9261@spearce.org> (raw)
In-Reply-To: <1254930273-1796-1-git-send-email-constantine.plotnikov@gmail.com>
Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> See man git-commit (the section "DISCUSSION"), for justification why
> UTF-8 should be used. Note that this was already correctly implemented
> in ObjectWriter.writeCommit(...) method. But Commit.decode() was not
> implemented in the same way for some reason.
Commit predates that encoding code in ObjectWriter.writeCommit and
it looks like we just forgot to go back and fix it. A very old bug.
Since our move to the Eclipse Foundation we really need to follow
their IP process, which for non-committers means creating a new bug
in their Bugzilla system:
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EGit
See also:
http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches
> .../tst/org/spearce/jgit/lib/T0003_Basic.java | 3 +++
> .../src/org/spearce/jgit/lib/Commit.java | 18 +++++++-----------
> 2 files changed, 10 insertions(+), 11 deletions(-)
--
Shawn.
prev parent reply other threads:[~2009-10-08 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 15:44 [JGIT PATCH] The default encoding for reading commits is UTF-8 rather than system default Constantine Plotnikov
2009-10-08 4:16 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008041609.GV9261@spearce.org \
--to=spearce@spearce.org \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).