From: "Shawn O. Pearce" <spearce@spearce.org>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] completion: fix alias listings with newlines
Date: Wed, 7 Oct 2009 21:29:17 -0700 [thread overview]
Message-ID: <20091008042917.GX9261@spearce.org> (raw)
In-Reply-To: <4ACCE417.5080907@gmail.com>
Stephen Boyd <bebarino@gmail.com> wrote:
> Johannes Sixt wrote:
> > Is it necessary to change the body of the loop? Your version spawns two
> > processes on each iteration, while the original spawned no processes.
Yes, we should try to avoid spawning a process here, it fires on
each completion attempt if I recall.
> Maybe a better solution would be to add --keys-only or something to
> git-config?
Or a format string with a language based escape like for-each-ref
supports? Might make it easier to use git config in scripts if we
can write things like:
git config --format='$data{%(key)}=%(value);' --perl
--
Shawn.
next prev parent reply other threads:[~2009-10-08 4:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 8:48 [PATCH 1/3] completion: fix alias listings with newlines Stephen Boyd
2009-10-07 8:48 ` [PATCH 2/3] completion: update am, commit, and log Stephen Boyd
2009-10-07 8:48 ` [PATCH 3/3] completion: add dirstat and friends to diff options Stephen Boyd
2009-10-07 19:45 ` Junio C Hamano
[not found] ` <20091007205059.GA16235@neumann>
2009-10-07 23:07 ` Junio C Hamano
[not found] ` <20091007233442.GJ6055@neumann>
2009-10-08 0:11 ` Stephen Boyd
2009-10-08 4:32 ` Shawn O. Pearce
2009-10-07 19:45 ` [PATCH 2/3] completion: update am, commit, and log Junio C Hamano
2009-10-07 9:33 ` [PATCH 1/3] completion: fix alias listings with newlines Johannes Sixt
2009-10-07 18:55 ` Stephen Boyd
2009-10-08 4:29 ` Shawn O. Pearce [this message]
2009-10-08 7:34 ` Stephen Boyd
2009-10-08 7:54 ` Johannes Sixt
2009-10-08 8:01 ` Stephen Boyd
2009-10-08 8:10 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008042917.GX9261@spearce.org \
--to=spearce@spearce.org \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).