From: "Shawn O. Pearce" <spearce@spearce.org>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Ted Pavlic <ted@tedpavlic.com>, git@vger.kernel.org
Subject: Re: [PATCH] Speedup bash completion loading
Date: Fri, 9 Oct 2009 08:39:36 -0700 [thread overview]
Message-ID: <20091009153936.GV9261@spearce.org> (raw)
In-Reply-To: <20091009152149.GA26171@tugrik.mns.mnsspb.ru>
Kirill Smelkov <kirr@mns.spb.ru> wrote:
> On Fri, Oct 09, 2009 at 07:46:06AM -0700, Shawn O. Pearce wrote:
> >
> > Squash this into the first patch and add the egrep change made by
> > Stephen Boyd "[PATCH 1/2] completion: fix completion of git <TAB><TAB>".
>
> While it is technically easy to do so, isn't this a bad idea to squash
> semantic changes and fixes into something which should be as close as
> code movement?
The ejection forces the code to build with /bin/bash, unless you
apply the trivial fixes related to IFS to make it work with dash.
As they are trivial the tiny semantic change during the code move
is just cleaner.
> Especially Stephen's fix?
I expect Junio to apply his patch first, and then yours. Since he
is changing a region you are moving, you need to account for it in
your patch, otherwise we have a conflict and/or a regression.
--
Shawn.
next prev parent reply other threads:[~2009-10-09 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 10:03 [PATCH] Speedup bash completion loading Kirill Smelkov
2009-10-05 15:25 ` Shawn O. Pearce
2009-10-05 16:58 ` Kirill Smelkov
2009-10-05 19:18 ` Ted Pavlic
2009-10-08 13:27 ` Kirill Smelkov
2009-10-08 15:02 ` Shawn O. Pearce
2009-10-08 15:10 ` Kirill Smelkov
2009-10-09 9:09 ` Kirill Smelkov
2009-10-09 14:46 ` Shawn O. Pearce
2009-10-09 15:21 ` Kirill Smelkov
2009-10-09 15:39 ` Shawn O. Pearce [this message]
2009-10-09 16:08 ` Kirill Smelkov
2009-10-09 16:14 ` Shawn O. Pearce
2009-10-10 0:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009153936.GV9261@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=kirr@mns.spb.ru \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).