From: Jeff King <peff@peff.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 (amend)] gitweb: Do not show 'patch' link for merge commits
Date: Fri, 9 Oct 2009 15:19:30 -0400 [thread overview]
Message-ID: <20091009191930.GA14534@coredump.intra.peff.net> (raw)
In-Reply-To: <200910091426.44976.jnareb@gmail.com>
On Fri, Oct 09, 2009 at 02:26:44PM +0200, Jakub Narebski wrote:
> Changes since v1:
> * Do not show 'patch' link for merge commits not only in 'commit'
> view, but also in 'commitdiff' view (more complete)
> * 'patch' link is shown also for root (parentless) commits; it
> works correctly thanks to passing '--root' option to git-format-patch
> (remove unnecessary restriction)
> * better commit message thanks to discussion with Jeff King
Thanks. I am not a gitweb expert, but those changes look good to me.
-Peff
next prev parent reply other threads:[~2009-10-09 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:21 [PATCH] gitweb: Do not show 'patch' link in 'commit' view for merges Jakub Narebski
2009-10-01 3:11 ` Jeff King
2009-10-01 7:36 ` Jakub Narebski
2009-10-01 7:55 ` Jeff King
2009-10-01 9:18 ` Jakub Narebski
2009-10-09 12:10 ` [PATCH v2] gitweb: Do not show 'patch' link for merge commits Jakub Narebski
2009-10-09 12:23 ` Jakub Narebski
2009-10-09 12:26 ` [PATCH v2 (amend)] " Jakub Narebski
2009-10-09 19:19 ` Jeff King [this message]
2009-10-10 0:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009191930.GA14534@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).