From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Miklos Vajna <vmiklos@frugalware.org>,
Matthew Cline <matt@nightrealms.com>,
git@vger.kernel.org
Subject: Re: git-commit feature request: pass editor command line options
Date: Wed, 14 Oct 2009 17:12:45 -0400 [thread overview]
Message-ID: <20091014211245.GA21670@sigill.intra.peff.net> (raw)
In-Reply-To: <7vvdihdc4f.fsf@alter.siamese.dyndns.org>
On Wed, Oct 14, 2009 at 12:11:28PM -0700, Junio C Hamano wrote:
> > Hmm, what is the use-case when using an option --foo is useful when
> > creating a commit, but not useful when crating a tag?
> >
> > Apart from introducing inconsistency...
>
> Not between commit and tag, but I can see you may want to auto-wrap for
> log message but forbid auto-wrap when editing rebase insn sheet during
> "rebase -i".
I think most people who want that just have their editor automagically
recognize the different situations based on the file name or contents. I
don't think the original author is wrong to want to be able to use
command-line options to do so, but if he is using a common editor like
vim or emacs, I think such autodetection has already been written.
-Peff
next prev parent reply other threads:[~2009-10-14 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 4:58 git-commit feature request: pass editor command line options Matthew Cline
2009-10-14 17:23 ` Miklos Vajna
2009-10-14 19:11 ` Junio C Hamano
2009-10-14 21:12 ` Jeff King [this message]
2009-10-14 20:03 ` Matthew Cline
2009-10-14 22:12 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014211245.GA21670@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matt@nightrealms.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).