git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: "Thomas Rast" <trast@student.ethz.ch>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>,
	"Sean Estabrooks" <seanlkml@sympatico.ca>,
	git@vger.kernel.org
Subject: Re: [PATCH] pull: refuse complete src:dst fetchspec arguments
Date: Fri, 23 Oct 2009 20:49:18 -0400	[thread overview]
Message-ID: <20091024004917.GA8012@sigio.peff.net> (raw)
In-Reply-To: <alpine.LNX.2.00.0910222334040.14365@iabervon.org>

On Thu, Oct 22, 2009 at 11:43:05PM -0400, Daniel Barkalow wrote:

> > But probably that is an artifact of the workflow. The scenario I am
> > describing above implies a somewhat centralized workflow, where the
> > shorthand contains all of the interesting information. In a totally
> > distributed, we-don't-share-anything-except-the-url-namespace setup of
> > an open source repo, the full URL makes more sense.
> > 
> > So maybe it is something that should be optional.
> 
> Surely you ought to be able to get the short form with "pull", though, if 
> you happen to like short forms. So it would make sense to decide how to 
> format the merge message based entirely on an option, not at all on 
> whether you use pull or fetch+merge.

Yeah, I think you are right. It _should_ be variable, but right now it
varies on something totally unrelated to what you want (how you invoked,
and not what type of repo setup you are using). So I agree a patch to
make it more consistent across fetch+merge versus pull would be good,
and then we can make a configuration option to choose one or the other.

-Peff

  reply	other threads:[~2009-10-24  0:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 18:23 [PATCH] pull: refuse complete src:dst fetchspec arguments Thomas Rast
2009-10-20 18:37 ` [RFC! PATCH] " Thomas Rast
2009-10-20 19:29 ` [PATCH] " Wesley J. Landaker
2009-10-20 20:30 ` Sean Estabrooks
2009-10-20 21:11   ` Junio C Hamano
2009-10-21  0:15   ` Daniel Barkalow
2009-10-21  0:29     ` Sean Estabrooks
2009-10-21  0:55       ` Daniel Barkalow
2009-10-21  1:35         ` Sean Estabrooks
2009-10-21  3:15         ` Björn Steinbrink
2009-10-21  4:32           ` Daniel Barkalow
2009-10-21  8:05           ` Thomas Rast
2009-10-23  2:54             ` Jeff King
2009-10-23  3:43               ` Daniel Barkalow
2009-10-24  0:49                 ` Jeff King [this message]
2009-10-24  1:22                   ` Junio C Hamano
2009-10-21  8:06   ` Thomas Rast
2009-11-15 12:24 ` Thomas Rast
2009-11-15 20:22   ` Junio C Hamano
2009-12-29 11:05 ` Nanako Shiraishi
2009-12-29 16:58   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091024004917.GA8012@sigio.peff.net \
    --to=peff@peff.net \
    --cc=B.Steinbrink@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=seanlkml@sympatico.ca \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).