git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Junio C Hamano <gitster@pobox.com>,
	vda.linux@googlemail.com, busybox@busybox.net,
	git@vger.kernel.org
Subject: Re: [PATCH] tar: on extract, -o is --no-same-owner
Date: Sat, 24 Oct 2009 12:06:21 +0200	[thread overview]
Message-ID: <20091024100621.GH4615@mx.loc> (raw)
In-Reply-To: <m38wf1dsjf.fsf@localhost.localdomain>

On Sat, Oct 24, 2009 at 02:56:33AM -0700, Jakub Narebski wrote:
>Andreas Schwab <schwab@linux-m68k.org> writes:
>> Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
>>> On Fri, Oct 23, 2009 at 02:26:53PM -0700, Junio C Hamano wrote:
>>>>Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
>>>>> On Fri, Oct 23, 2009 at 10:25:24PM +0200, Bernhard Reutner-Fischer wrote:
>>>>>> On Fri, Oct 23, 2009 at 10:15:43PM +0200, Bernhard Reutner-Fischer wrote:
>>>>>>>
>>>>>>> GNU tar-1.22 handles 'o' as no-same-owner only on extract,
>>>>>>> on create, 'o' would be --old-archive.
>
>>>>>>  	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_instdir_SQ)'
>>>>>>  	(cd blt && $(TAR) cf - .) | \
>>>>>> -	(cd '$(DESTDIR_SQ)$(template_instdir_SQ)' && umask 022 && $(TAR) xfo -)
>>>>>> +	(cd '$(DESTDIR_SQ)$(template_instdir_SQ)' && umask 022 && $(TAR) x --no-numeric-owner -f -)
>>>>>
>>>>> argh, sorry! --no-same-owner of course.
>>>>
>>>> Either way, your change would break non-GNU tar implementations that are
>>>> properly POSIX.1, isn't it?
>>>
>>> I suppose xf - -o would work?
>> 
>> Isn't that the same as 'xfo -'?
>> 
>> (tar isn't specified by POSIX, btw.)
>
>I don't quite understand why 'o' has to be spelled using long name
>--no-same-owner, instead of just correcting the ordering of "old style"

It doesn't have to be, right.

>short options to have 'f' last, i.e.
>
>  $(TAR) xof -
>
>and not (current)
>
>  $(TAR) xfo -

any of "xf - -o" or "xof -" would work for me.

  reply	other threads:[~2009-10-24 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1256328943-22136-1-git-send-email-rep.dot.nop@gmail.com>
2009-10-23 20:25 ` [PATCH] tar: on extract, -o is --no-same-owner Bernhard Reutner-Fischer
2009-10-23 21:06   ` Bernhard Reutner-Fischer
2009-10-23 21:26     ` Junio C Hamano
2009-10-24  9:17       ` Bernhard Reutner-Fischer
2009-10-24  9:49         ` Andreas Schwab
2009-10-24  9:56           ` Jakub Narebski
2009-10-24 10:06             ` Bernhard Reutner-Fischer [this message]
2009-10-24 10:06             ` Andreas Schwab
2009-10-24 10:05           ` Bernhard Reutner-Fischer
2009-10-24 10:44             ` Andreas Schwab
2009-10-24 13:06               ` Andreas Schwab
2009-10-24 19:25                 ` Junio C Hamano
2009-10-24 23:32               ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091024100621.GH4615@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=busybox@busybox.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=schwab@linux-m68k.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).