git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Jeffrey Middleton <jefromi@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>, git@vger.kernel.org
Subject: Re: git update --prune issue
Date: Tue, 27 Oct 2009 12:29:36 -0400	[thread overview]
Message-ID: <20091027162936.GA8130@sigill.intra.peff.net> (raw)
In-Reply-To: <4389ce950910270807o69d51155xb083f34bb31e1dae@mail.gmail.com>

On Tue, Oct 27, 2009 at 10:07:27AM -0500, Jeffrey Middleton wrote:

> > Do you get the same problem if you do the steps individually, i.e.:
> >
> > git remote update steph
> > git remote prune steph
> > git remote update kevin
> 
> I don't *think* I'll see it this way - I was doing essentially this
> prior to introduction of the --prune option, and never saw it then.

I suspect you are seeing git keeping an invalid cache of the set of refs
within a single program. Your original report had:

> Pruning steph
> URL: /users/sdewet/CxTF_DEV/CxTF_DB/
>  * [pruned] steph/beta_gc_dev_old
> Updating kevin
> error: refs/remotes/steph/beta_gc_dev does not point to a valid object!
> error: refs/remotes/steph/beta_veh_dev does not point to a valid object!

The "pruned" line basically means that we are deleting that ref, and
then we complain immediately about that very ref (which is probably
pointing to the null sha1 or something at this point). We tend to cache
packed refs, so that may be the cause.

So either we need to invalidate that ref from the cache when it gets
deleted, or perhaps we are already invalidating it and we need to be
respecting that invalidation in other parts of the code. I'll take a
look.

-Peff

  reply	other threads:[~2009-10-27 16:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 22:08 git update --prune issue Jeffrey Middleton
2009-10-27  8:42 ` Michael J Gruber
2009-10-27 15:07   ` Jeffrey Middleton
2009-10-27 16:29     ` Jeff King [this message]
2009-10-27 16:39       ` Jeffrey Middleton
2009-10-27 16:40       ` Clemens Buchacher
2009-10-27 16:50         ` Jeff King
2009-10-27 18:46           ` Jeff King
2009-10-27 23:30             ` Björn Steinbrink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027162936.GA8130@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=jefromi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).