From: Johan Herland <johan@herland.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH 1/7] Refactor git_remote_cvs to a more generic git_remote_helpers
Date: Thu, 29 Oct 2009 13:05:26 +0100 [thread overview]
Message-ID: <200910291305.26523.johan@herland.net> (raw)
In-Reply-To: <1256798426-21816-2-git-send-email-srabbelier@gmail.com>
On Thursday 29 October 2009, Sverre Rabbelier wrote:
> This in an effort to allow future remote helpers written in python to
> re-use the non-cvs-specific code.
>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
> CC: Johan Herland <johan@herland.net>
> ---
>
> As discussed with Johan Herland, refactored git_remote_cvs into a
> more reusable git_remote_helpers module.
It's hard to review this patch for a couple of reasons:
1. It's over 200K large, which causes it to be blocked by the Git mailing
list (100K limit, I believe).
2. The patch renames some files, but instead of simply stating the rename,
the patch lists the entire file twice (deletion + creation)
Fortunately, you can easily solve both problems by rerolling the patch with
the -M flag to git-format-patch.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2009-10-29 12:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 6:40 [PATCH 0/7] Prepare git-remote-helpers series for hg support Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 2/7] .gitignore: add git-remote-cvs Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 3/7] Add notify and warn to util.py Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 4/7] Allow both url and foreign vcs in remote config Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 5/7] Finally make remote helper support useful Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 6/7] When updating refs after a fetch, resolve the symref if set Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 7/7] Factor ref updating out of fetch_with_import Sverre Rabbelier
2009-10-29 14:22 ` Shawn O. Pearce
2009-10-29 15:53 ` Sverre Rabbelier
2009-10-29 15:56 ` Shawn O. Pearce
2009-10-29 16:32 ` Sverre Rabbelier
2009-10-29 17:22 ` Daniel Barkalow
2009-10-29 17:39 ` Sverre Rabbelier
2009-10-29 18:43 ` Daniel Barkalow
2009-10-29 18:47 ` Sverre Rabbelier
[not found] ` <1256798426-21816-2-git-send-email-srabbelier@gmail.com>
2009-10-29 12:05 ` Johan Herland [this message]
2009-10-29 15:48 ` [PATCH 1/7] Refactor git_remote_cvs to a more generic git_remote_helpers Sverre Rabbelier
-- strict thread matches above, loose matches on Subject: below --
2009-10-29 15:47 Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910291305.26523.johan@herland.net \
--to=johan@herland.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).