From: Jeff King <peff@peff.net>
To: Klaus Ethgen <Klaus@Ethgen.de>
Cc: 553296@bugs.debian.org, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: Bug#553296: gitignore broken completely
Date: Fri, 30 Oct 2009 16:05:00 -0400 [thread overview]
Message-ID: <20091030200500.GA24831@coredump.intra.peff.net> (raw)
In-Reply-To: <20091030200148.GD10671@ikki.ethgen.de>
On Fri, Oct 30, 2009 at 09:01:48PM +0100, Klaus Ethgen wrote:
> > +test_expect_success 'ls-files -i lists only tracked-but-ignored files' '
> > + echo content >other-file &&
> > + git add other-file &&
> > + echo file >expect &&
> > + git ls-files -i --exclude-standard >output &&
> > + test_cmp expect output
> > +'
> > +
> > test_done
>
> Do that fit? shouldn't it be "test_cmp other-file output"? "git ls-files
> -i --exclude-standard" should show the files in the index that are also
> in the exclude list. And you only add other-file to the index. And
> shouldn't there be also a "echo other-file > .gitignore"?
No, because it is building on the previous tests. The point of the test
is:
- we already have 'file' tracked and in gitignore (from previous
tests in the series)
- we add other-file to have some other file which is tracked but not
in gitignore
- we check the output of "ls-files -i" to make sure that "file" is
there, but "other-file" is not
-Peff
next prev parent reply other threads:[~2009-10-30 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091029233458.GA32764@ikki.ethgen.de>
[not found] ` <20091030162857.26604.qmail@67b7e3b41a17c8.315fe32.mid.smarden.org>
[not found] ` <20091030165903.GA10671@ikki.ethgen.de>
2009-10-30 17:38 ` Bug#553296: gitignore broken completely Jeff King
2009-10-30 18:23 ` Klaus Ethgen
2009-10-30 18:41 ` Jeff King
2009-10-30 19:05 ` Jeff King
2009-10-30 19:51 ` Junio C Hamano
2009-10-30 19:52 ` Jeff King
2009-10-30 20:05 ` Klaus Ethgen
2009-10-30 20:01 ` Klaus Ethgen
2009-10-30 20:05 ` Jeff King [this message]
2009-10-30 20:08 ` Klaus Ethgen
2009-10-30 19:41 ` Junio C Hamano
2009-10-30 19:43 ` Jeff King
2009-10-30 21:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030200500.GA24831@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=553296@bugs.debian.org \
--cc=Klaus@Ethgen.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).