From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] clone: detect extra arguments
Date: Sat, 31 Oct 2009 12:32:27 +0100 [thread overview]
Message-ID: <200910311232.27278.johan@herland.net> (raw)
In-Reply-To: <20091030145108.GA881@coredump.intra.peff.net>
On Friday 30 October 2009, Jeff King wrote:
> On Fri, Oct 30, 2009 at 10:45:25AM -0400, Jeff King wrote:
> > But looking at the usage message, there is some potential for cleanup.
>
> Also, we should probably do this (I did it as a patch on master, though,
> as it is an independent fix):
>
> -- >8 --
> Subject: [PATCH] clone: fix --recursive usage message
>
> Looks like a mistaken cut-and-paste in e7fed18a.
Yes. Please fix my screwup.
> Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Johan Herland <johan@herland.net>
> ---
> builtin-clone.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin-clone.c b/builtin-clone.c
> index 5762a6f..436e8da 100644
> --- a/builtin-clone.c
> +++ b/builtin-clone.c
> @@ -61,7 +61,7 @@ static struct option builtin_clone_options[] = {
> OPT_BOOLEAN('s', "shared", &option_shared,
> "setup as shared repository"),
> OPT_BOOLEAN(0, "recursive", &option_recursive,
> - "setup as shared repository"),
> + "initialize submodules in the clone"),
> OPT_STRING(0, "template", &option_template, "path",
> "path the template repository"),
> OPT_STRING(0, "reference", &option_reference, "repo",
>
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
prev parent reply other threads:[~2009-10-31 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 8:10 [PATCH] clone: detect extra arguments Jonathan Nieder
2009-10-29 16:06 ` Jeff King
2009-10-30 11:19 ` Jonathan Nieder
2009-10-30 14:45 ` Jeff King
2009-10-30 14:51 ` Jeff King
2009-10-31 11:32 ` Johan Herland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910311232.27278.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).