From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC/PATCH 3/3] bisect: simplify calling visualizer using '--bisect-refs'
Date: Wed, 04 Nov 2009 05:00:03 +0100 [thread overview]
Message-ID: <20091104040004.4545.72084.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20091104034312.4545.2176.chriscool@tuxfamily.org>
It is now shorter and safer to use the new '--bisect-refs' revision
machinery option, than to compute the refs that we must pass.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
git-bisect.sh | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 8b3c585..41b9118 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -300,8 +300,7 @@ bisect_visualize() {
esac
fi
- not=$(git for-each-ref --format='%(refname)' "refs/bisect/good-*")
- eval '"$@"' refs/bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
+ eval '"$@"' --bisect-refs -- $(cat "$GIT_DIR/BISECT_NAMES")
}
bisect_reset() {
--
1.6.5.1.gaf97d
next prev parent reply other threads:[~2009-11-04 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 4:00 [RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option Christian Couder
2009-11-04 4:00 ` [RFC/PATCH 1/3] t6030: show "rev-list --bisect" breakage when bisecting Christian Couder
2009-11-04 4:00 ` [RFC/PATCH 2/3] revision: change '--bisect' rev machinery argument to 'bisect-refs' Christian Couder
2009-11-04 4:00 ` Christian Couder [this message]
2009-11-04 18:25 ` [RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option Junio C Hamano
2009-11-04 18:32 ` Linus Torvalds
2009-11-04 18:35 ` Linus Torvalds
2009-11-04 19:22 ` Junio C Hamano
2009-11-04 21:26 ` Christian Couder
2009-11-04 21:52 ` Junio C Hamano
2009-11-05 5:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104040004.4545.72084.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).