From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: Problem with "From:" line on "git format-patch" generated patches Date: Wed, 4 Nov 2009 03:49:03 -0500 Message-ID: <20091104084903.GA1137@coredump.intra.peff.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Santi =?utf-8?B?QsOpamFy?= , Git Mailing List To: =?utf-8?B?QW5kcsOp?= Goddard Rosa X-From: git-owner@vger.kernel.org Wed Nov 04 09:49:16 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5bYJ-0007Bd-Dj for gcvg-git-2@lo.gmane.org; Wed, 04 Nov 2009 09:49:15 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704AbZKDItE convert rfc822-to-quoted-printable (ORCPT ); Wed, 4 Nov 2009 03:49:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754659AbZKDItD (ORCPT ); Wed, 4 Nov 2009 03:49:03 -0500 Received: from peff.net ([208.65.91.99]:54997 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157AbZKDItD (ORCPT ); Wed, 4 Nov 2009 03:49:03 -0500 Received: (qmail 9188 invoked by uid 107); 4 Nov 2009 08:52:49 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.40) with (AES128-SHA encrypted) SMTP; Wed, 04 Nov 2009 03:52:49 -0500 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Wed, 04 Nov 2009 03:49:03 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Nov 03, 2009 at 04:06:39PM -0200, Andr=C3=A9 Goddard Rosa wrote= : > I'm not using any specific tool for inputting the git-format-patch, > but instead I'm sending the files generated by it through gmail as an > inlined patch in the email body. >=20 > I like the convenience of format-patch for generating the patch files= , > but in this case, formatting the header as rfc2047 is not necessary > and makes a funny/garbled output in my patch submission. >=20 > Do you have a suggestion for my workflow? I don't think there's currently a way to turn off the rfc2047 from within format-patch. You can generate a single patch with the same format using: git log -1 -p --stat --summary \ --pretty=3Dtformat:'From: %an <%ae>%nDate: %aD%nSubject: [PATCH] %s= %n%n%b' but it won't do nice things like putting one patch in each file. Probably it would make sense for format-patch to have an option to indicate that you are going to inline these patches into a different MUA. So drop the 'From' mbox header line, don't rfc2047 encode, and maybe some other behaviors. I do the same thing (including inline in mutt), but I just delete the unwanted lines manually, and fortunately m= y name doesn't contain any non-ascii characters. ;) -Peff