From: Jonathan Nieder <jrnieder@gmail.com>
To: Ben Walton <bwalton@artsci.utoronto.ca>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] Set Makefile variables from configure
Date: Wed, 4 Nov 2009 14:16:58 -0600 [thread overview]
Message-ID: <20091104201657.GA30073@progeny.tock> (raw)
In-Reply-To: <1257363937-sup-5123@ntdws12.chass.utoronto.ca>
Ben Walton wrote:
> Excerpts from Junio C Hamano's message of Wed Nov 04 14:36:32 -0500 2009:
>
>> I am a bit puzzled about the "warning" logic. Is this because you expect
>> variables we typically give YesPlease/NoThanks as their values will not be
>> handled with this new PARSE_WITH_SET_MAKE_VAR() macro?
>
> No, this is because it's perfectly acceptable, in my opinion for a
> user to say:
>
> --with-pager=no
> or
> --with-editor=yes
More to the point, that’s what autoconf gives for "--without-pager" or
plain "--with-editor". It seems strange to silently use PAGER=no or
EDITOR=yes in that case.
Maybe the options should just be --pager=foo and --editor=bar, which
would be less misleading and avoid this problem. But this is not my
itch (I find it cleaner to use the Makefile directly), so I have no
strong opinion. Unfortunately, my autoconf-fu is too weak for a demo.
Jonathan
next prev parent reply other threads:[~2009-11-04 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 20:41 [PATCH 0/2] Set Makefile variables from configure Ben Walton
2009-10-31 20:41 ` [PATCH 1/2] configure: add function to directly set Makefile variables Ben Walton
2009-10-31 20:41 ` [PATCH 2/2] configure: allow user to set gitconfig, pager and editor Ben Walton
2009-11-03 17:25 ` [PATCH 0/2] Set Makefile variables from configure Ben Walton
2009-11-03 21:54 ` Jonathan Nieder
2009-11-03 22:21 ` Jonathan Nieder
2009-11-04 18:05 ` Ben Walton
2009-11-04 18:05 ` [PATCH 1/2] configure: add macro to set arbitrary make variables Ben Walton
2009-11-04 18:06 ` [PATCH 2/2] configure: add settings for gitconfig, editor and pager Ben Walton
2009-11-04 19:36 ` [PATCH 0/2] Set Makefile variables from configure Junio C Hamano
2009-11-04 19:47 ` Ben Walton
2009-11-04 19:56 ` Junio C Hamano
2009-11-04 20:16 ` Ben Walton
2009-11-04 20:16 ` Jonathan Nieder [this message]
2009-11-04 18:07 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104201657.GA30073@progeny.tock \
--to=jrnieder@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).