From: Johan Herland <johan@herland.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Daniel Barkalow <barkalow@iabervon.org>,
David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH v2 13/13] Add Python support library for remote helpers
Date: Thu, 05 Nov 2009 08:55:01 +0100 [thread overview]
Message-ID: <200911050855.01164.johan@herland.net> (raw)
In-Reply-To: <1257364098-1685-14-git-send-email-srabbelier@gmail.com>
On Wednesday 04 November 2009, Sverre Rabbelier wrote:
> This patch introduces parts of a Python package called
> "git_remote_helpers" containing the building blocks for
> python helper.
> The actual remote helpers itself are NOT part of this patch.
>
> The patch includes the necessary Makefile additions to build and install
> the git_remote_cvs Python package along with the rest of Git.
There are a few typos in the above. How about:
This patch introduces parts of a Python package called
"git_remote_helpers" containing the building blocks for
remote helpers written in Python.
No actual remote helpers are part of this patch, the patch
only includes the common basics needed to start writing such
helpers.
> The patch includes the necessary Makefile additions to build and install
> the git_remote_cvs Python package along with the rest of Git.
s/git_remote_cvs/git_remote_helpers/
> This patch is based on Johan Herland's git_remote_cvs patch and
> has been improved by the following contributions:
> - David Aguilar: Lots of Python coding style fixes
> - David Aguilar: DESTDIR support in Makefile
>
> Cc: David Aguilar <davvid@gmail.com>
> Cc: Johan Herland <johan@herland.net>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
> ---
Otherwise it all looks good. Nice work!
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2009-11-05 7:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 19:48 [PATCH v2 00/13] Reroll of the remote-vcs-helper series Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 01/13] Fix memory leak in helper method for disconnect Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 02/13] Allow programs to not depend on remotes having urls Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 03/13] Use a function to determine whether a remote is valid Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 04/13] Allow fetch to modify refs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 05/13] Add a config option for remotes to specify a foreign vcs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 06/13] Allow specifying the remote helper in the url Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 07/13] Add support for "import" helper command Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 08/13] Write local refs written by the "import" helper command only once Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 09/13] Honour the refspec when updating refs after import Sverre Rabbelier
2009-11-04 21:20 ` Daniel Barkalow
2009-11-04 21:21 ` Sverre Rabbelier
2009-11-04 21:30 ` Daniel Barkalow
2009-11-05 1:45 ` Sverre Rabbelier
2009-11-05 5:34 ` Daniel Barkalow
2009-11-05 6:53 ` Daniel Barkalow
2009-11-05 23:51 ` Sverre Rabbelier
2009-11-06 0:19 ` Daniel Barkalow
2009-11-06 0:28 ` Sverre Rabbelier
2009-11-06 0:37 ` Daniel Barkalow
2009-11-06 6:05 ` Junio C Hamano
2009-11-04 19:48 ` [PATCH v2 10/13] Allow helpers to report in "list" command that the ref is unchanged Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 11/13] Allow helpers to request the path to the .git directory Sverre Rabbelier
2009-11-04 21:35 ` Daniel Barkalow
2009-11-04 22:06 ` Sverre Rabbelier
2009-11-04 22:27 ` Daniel Barkalow
2009-11-04 22:42 ` Sverre Rabbelier
2009-11-04 23:17 ` Daniel Barkalow
2009-11-04 23:18 ` Sverre Rabbelier
2009-11-04 23:25 ` Daniel Barkalow
2009-11-05 0:04 ` Junio C Hamano
2009-11-05 0:15 ` Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 12/13] Basic build infrastructure for Python scripts Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 13/13] Add Python support library for remote helpers Sverre Rabbelier
2009-11-05 7:55 ` Johan Herland [this message]
2009-11-06 0:14 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911050855.01164.johan@herland.net \
--to=johan@herland.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).