Git development
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt.net>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] pre-commit.sample: Diff against the empty tree when HEAD is invalid
Date: Fri, 6 Nov 2009 18:11:35 +0100	[thread overview]
Message-ID: <20091106171126.GA42592@book.hvoigt.net> (raw)
In-Reply-To: <20091105105757.GA31787@atjola.homenet>

Hallo,

On Thu, Nov 05, 2009 at 11:57:57AM +0100, Björn Steinbrink wrote:
> This was already the case for the old "diff --check" call, but the new
> one that checks whether there are any non-ascii file names was missing
> it, making that check fail for root commits.
> 
> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>

[...]
> -	test "$(git diff --cached --name-only --diff-filter=A -z |
> +	test "$(git diff --cached --name-only --diff-filter=A -z $against |

Looks sensible to me. Thanks for that fix.

As this went unnoticed for quite some time it seems as either not many
are actually using our example hook or at least not starting new
projects with it. I fit in the latter group I suppose.

cheers Heiko

      reply	other threads:[~2009-11-06 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 10:57 [PATCH] pre-commit.sample: Diff against the empty tree when HEAD is invalid Björn Steinbrink
2009-11-06 17:11 ` Heiko Voigt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106171126.GA42592@book.hvoigt.net \
    --to=hvoigt@hvoigt.net \
    --cc=B.Steinbrink@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox