From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Allowing push --dry-run through fetch url
Date: Mon, 9 Nov 2009 08:56:07 +0100 [thread overview]
Message-ID: <20091109075607.GA16706@glandium.org> (raw)
In-Reply-To: <7vfx8obz2o.fsf@alter.siamese.dyndns.org>
On Sun, Nov 08, 2009 at 11:23:27AM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > Usually, when I run git push --dry-run, it's to check that what follows
> > (usually the refspec part) does what I want it to do, such as not pushing
> > tags I didn't intend to push(*), and stuff like that.
>
> Ahh, that one.
>
> That reminds me of a topic that we discussed but went away without
> reaching the conclusion on adding a "confirmation: are you sure this
> pushes what you want?" to the command. I had a doubt about the patch back
> then which was that it hardcoded a tty interaction and it would be hard to
> retrofit it to help GUI frontends (so my suggestion was to use something
> like hooks mechanism, perhaps --confirm=this-script and allow it to do its
> GUI thing), but thinking about it again, they can always use "expect" to
> drive the interaction with the confirmation prompt, so it may not a big
> deal after all---we might want to resurrect the topic.
How about an option to have the confirmation asked, quite like
cp/mv/rm's -i option ?
> That was an unrelated, independent thought on your comment, but if we did
> so, you might not even have to try to use --dry-run on git:// transport.
Sounds like a good trade-off.
Cheers
Mike
next prev parent reply other threads:[~2009-11-09 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 7:37 Allowing push --dry-run through fetch url Mike Hommey
2009-11-06 8:49 ` Junio C Hamano
2009-11-06 8:59 ` Mike Hommey
2009-11-06 9:02 ` Junio C Hamano
2009-11-06 9:21 ` Mike Hommey
2009-11-06 9:44 ` Junio C Hamano
2009-11-06 9:53 ` Mike Hommey
2009-11-08 19:23 ` Junio C Hamano
2009-11-09 7:56 ` Mike Hommey [this message]
2009-12-29 11:05 ` Nanako Shiraishi
2009-12-29 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109075607.GA16706@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).