From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: [RFC, PATCH] git send-email: Make --no-chain-reply-to the default
Date: Tue, 10 Nov 2009 05:08:47 +0100 [thread overview]
Message-ID: <20091110040847.GC29454@elte.hu> (raw)
In-Reply-To: <1257789555.4108.348.camel@laptop>
(moved from lkml to the Git list)
* Peter Zijlstra <peterz@infradead.org> wrote:
> > Mailer:
> > git-send-email 1.6.5.2
>
> Please teach your git-send-email thing to use --no-chain-reply-to.
about half of every patch series that gets sent to me on lkml is
unreadable in my email client due to the default threading that
git-send-email does. It looks like this:
28685 r T Nov 05 Hitoshi Mitake ( 31) [PATCH v5 0/7] Adding general performance benchmarki
28686 T Nov 05 Hitoshi Mitake ( 31) +->[PATCH v5 1/7] Adding new directory and header fo
28687 T Nov 05 Hitoshi Mitake ( 368) | +->[PATCH v5 2/7] sched-messaging.c: benchmark for
28688 T Nov 05 Hitoshi Mitake ( 148) | | +->[PATCH v5 3/7] sched-pipe.c: benchmark for pi
28689 T Nov 05 Hitoshi Mitake ( 149) | | | +->[PATCH v5 4/7] builtin-bench.c: General fra
28690 T Nov 05 Hitoshi Mitake ( 24) | | | | +->[PATCH v5 5/7] Modifying builtin.h for ne
28691 T Nov 05 Hitoshi Mitake ( 25) | | | | | +->[PATCH v5 6/7] Modyfing perf.c for subc
28692 T Nov 05 Hitoshi Mitake ( 30) | | | | | | +->[PATCH v5 7/7] Modyfing Makefile to b
and with 10 or more patches it's an absolute pain as threading depth
increases. Furthermore, the subject lines are not aligned vertically,
making it very hard to see the general shortlog-alike structure of the
series, at a glance. Plus i dont even _see_ the title over a certain
depth, as i run out of screen real estate.
So ... the question would be ... could git-send-email flip its default
please, via the patch below? Am i missing something subtle about why
this default was chosen?
Ingo
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/git-send-email.perl b/git-send-email.perl
index a0279de..ff00940 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -188,7 +188,7 @@ my (@suppress_cc);
my %config_bool_settings = (
"thread" => [\$thread, 1],
- "chainreplyto" => [\$chain_reply_to, 1],
+ "chainreplyto" => [\$chain_reply_to, 0],
"suppressfrom" => [\$suppress_from, undef],
"signedoffbycc" => [\$signed_off_by_cc, undef],
"signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
next parent reply other threads:[~2009-11-10 4:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1257786206-9208-1-git-send-email-mitake@dcl.info.waseda.ac.jp>
[not found] ` <1257789555.4108.348.camel@laptop>
2009-11-10 4:08 ` Ingo Molnar [this message]
2009-11-10 5:12 ` [RFC, PATCH] git send-email: Make --no-chain-reply-to the default Jay Soffian
2009-11-10 5:22 ` Ingo Molnar
2009-11-10 6:05 ` Junio C Hamano
2009-11-10 5:29 ` Junio C Hamano
2009-11-10 7:19 ` Ingo Molnar
2009-11-10 18:29 ` Ingo Molnar
2009-11-10 7:32 ` Peter Zijlstra
2009-11-10 19:46 ` Michael Witten
2009-11-10 19:58 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110040847.GC29454@elte.hu \
--to=mingo@elte.hu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).