From: Jeff King <peff@peff.net>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Define $PERL_PATH in test-lib.sh
Date: Wed, 11 Nov 2009 03:43:16 -0500 [thread overview]
Message-ID: <20091111084316.GA1799@sigill.intra.peff.net> (raw)
In-Reply-To: <20091111084014.GE8896@plop>
On Wed, Nov 11, 2009 at 09:40:14AM +0100, Philippe Bruhat (BooK) wrote:
> > Hmm, but that means two separate definitions in ./Makefile and
> > t/test-lib.sh must be kept in sync forever, and there is not even a
> > comment next to the line that requires such care in your patch to help
> > people who might want to change these lines in the future.
>
> Is there a way to obtain whatever value was computed in the Makefile,
> or should I just add a comment in all-caps saying "keep this in sync
> with the default value in the top level Makefile"? (and a more detailed
> commit message)
Yes. Did you miss the second half of my other message?
http://article.gmane.org/gmane.comp.version-control.git/132561
-Peff
prev parent reply other threads:[~2009-11-11 8:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 10:46 [PATCH] Define $PERL_PATH in test-lib.sh Philippe Bruhat (BooK)
2009-11-10 12:23 ` Jeff King
2009-11-10 13:33 ` Philippe Bruhat (BooK)
2009-11-15 9:12 ` Junio C Hamano
2009-11-16 23:48 ` Philippe Bruhat (BooK)
2009-11-16 23:53 ` [PATCH] Make sure $PERL_PATH is defined when the test suite is run Philippe Bruhat (BooK)
2009-11-17 0:10 ` Junio C Hamano
2009-11-17 0:17 ` Philippe Bruhat (BooK)
2009-11-17 0:20 ` Philippe Bruhat (BooK)
2009-11-17 8:30 ` Johannes Sixt
2009-11-17 8:35 ` Philippe Bruhat (BooK)
2009-11-17 18:25 ` Junio C Hamano
2009-11-17 8:42 ` Philippe Bruhat (BooK)
2009-11-10 12:26 ` [PATCH] Define $PERL_PATH in test-lib.sh Johannes Sixt
2009-11-10 13:34 ` Philippe Bruhat (BooK)
2009-11-10 20:17 ` Junio C Hamano
2009-11-11 8:40 ` Philippe Bruhat (BooK)
2009-11-11 8:43 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111084316.GA1799@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=book@cpan.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).