git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: commit log encoding [Was: [PATCH 1/2] tree-wide: fix typos "offest" -> "offset"]
Date: Wed, 11 Nov 2009 15:13:43 +0100	[thread overview]
Message-ID: <20091111141342.GA1849@pengutronix.de> (raw)
In-Reply-To: <alpine.LSU.2.00.0911111318260.15039@wotan.suse.de>

On Wed, Nov 11, 2009 at 01:19:32PM +0100, Jiri Kosina wrote:
> On Wed, 11 Nov 2009, Uwe Kleine-König wrote:
> 
> > > Thanks for noticing, I had a bug in my git charset config for quite some 
> > > time. Fixed it now.
> > Now my name is latin1 encoded.  It should be utf-8, doesn't it?
> 
> It's not latin1, it's iso-8859-2
For my name it makes no difference.

>                                   which is what I use on my terminals.
> And git can handle that fine too (it stores the encoding together with the 
> commit).
Ah, OK, that's news to me, but you're right.  I have here:

	~/gsrc/linux-2.6$ git cat-file commit 30ff0743f88a70f52a4de5ea5bcb1fd29bcfab2d
	tree 6121d35bb2606878be636e897fa77cd51804d724
	parent 916b7c73db593510d5c38706be2f2888981747ee
	author Uwe Kleine-K�nig <u.kleine-koenig@pengutronix.de> 1256757064 +0100
	committer Jiri Kosina <jkosina@suse.cz> 1257780224 +0100
	encoding ISO-8859-2

	tree-wide: fix typos "couter" -> "counter"

	This patch was generated by

		git grep -E -i -l 'couter' | xargs -r perl -p -i -e 's/couter/counter/'

	Signed-off-by: Uwe Kleine-K�nig <u.kleine-koenig@pengutronix.de>
	Signed-off-by: Jiri Kosina <jkosina@suse.cz>

So the remaining question is: Does the encoding specified in the
encoding "header" also apply to the other headers?

If yes[1] then there's a bug in git-shortlog

	~/gsrc/linux-2.6$ git shortlog linus/master..trivial/for-next | grep Uwe
	Uwe Kleine-K�nig (5):

(with linus/master = 799dd75b1a8380a967c929a4551895788c374b31,
trivial/for-next = 4030ec040a0e21fe9953da70eaa59ee7b4f2297b).
 
Best regards
Uwe

[1] git log linus/master..trivial/for-next looks OK, so I suspect it
does apply.

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

       reply	other threads:[~2009-11-11 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1256757064-13669-1-git-send-email-u.kleine-koenig@pengutronix.de>
     [not found] ` <alpine.LSU.2.00.0911021600530.4203@wotan.suse.de>
     [not found]   ` <20091103081447.GA20204@pengutronix.de>
     [not found]     ` <alpine.LSU.2.00.0911031144300.9988@wotan.suse.de>
     [not found]       ` <20091111114206.GA19652@pengutronix.de>
     [not found]         ` <alpine.LSU.2.00.0911111318260.15039@wotan.suse.de>
2009-11-11 14:13           ` Uwe Kleine-König [this message]
2009-11-24 15:12             ` [PATCH] shortlog: respect commit encoding Uwe Kleine-König
2009-11-24 16:08               ` more problems with commit encoding [Was: [PATCH] shortlog: respect commit encoding] Uwe Kleine-König
2009-11-25  1:12               ` [PATCH] shortlog: respect commit encoding Junio C Hamano
2009-11-25 14:00                 ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111141342.GA1849@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=git@vger.kernel.org \
    --cc=jkosina@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).