From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, <git@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter
Date: Wed, 11 Nov 2009 19:36:04 +0100 [thread overview]
Message-ID: <200911111936.06332.trast@student.ethz.ch> (raw)
In-Reply-To: <7vocn8q5v2.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
>
> Up to this point, nothing mentions the name of the new option. Please
> write your log for a person who needs to write the release notes by
> looking at "git shortlog" output ;-)
>
> I am wondering if this even needs an option to trigger. Shouldn't you
> want this behaviour always when you give any pathspec?
>
> What are the sane reasons to leave the rewritten ref to point at the old
> commit, essentially making the rewritten history unreachable?
Fear of hysterical raisins, nothing else. I cannot really see a
use-case of the original behaviour, and since it does not change the
behaviour in the case of an unfiltered rewrite, it should be safe to
always be enabled.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2009-11-11 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 18:16 [PATCH 1/2] filter-branch: stop special-casing $filter_subdir argument Thomas Rast
2009-10-21 18:16 ` [PATCH 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter Thomas Rast
2009-10-21 18:28 ` [PATCH v2 1/2] filter-branch: stop special-casing $filter_subdir argument Thomas Rast
2009-10-21 18:28 ` [PATCH v2 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter Thomas Rast
2009-10-22 6:06 ` [PATCH v2 1/2] filter-branch: stop special-casing $filter_subdir argument Johannes Sixt
2009-10-22 8:05 ` Thomas Rast
2009-10-22 8:31 ` Johannes Sixt
2009-10-28 22:59 ` [PATCH v3 " Thomas Rast
2009-10-28 22:59 ` [PATCH v3 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter Thomas Rast
2009-10-29 7:38 ` Johannes Sixt
2009-10-29 7:35 ` [PATCH v3 1/2] filter-branch: stop special-casing $filter_subdir argument Johannes Sixt
2009-11-10 21:04 ` [PATCH v4 " Thomas Rast
2009-11-10 21:04 ` [PATCH v4 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter Thomas Rast
2009-11-11 8:30 ` [PATCH v4 1/2] filter-branch: stop special-casing $filter_subdir argument Johannes Sixt
2009-11-11 8:53 ` [PATCH v5 " Johannes Sixt
2009-11-11 8:55 ` [PATCH v5 2/2] filter-branch: nearest-ancestor rewriting outside subdir filter Johannes Sixt
2009-11-11 18:22 ` Junio C Hamano
2009-11-11 18:36 ` Thomas Rast [this message]
2009-11-11 8:58 ` [PATCH v5 1/2] filter-branch: stop special-casing $filter_subdir argument Johannes Sixt
2009-11-11 10:24 ` Thomas Rast
2009-11-11 12:10 ` Johannes Sixt
2009-11-11 18:00 ` [PATCH v4 " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911111936.06332.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).