Git development
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Toby Allsopp <Toby.Allsopp@navman.co.nz>
Cc: git@vger.kernel.org, Sam Vilain <sam.vilain@catalyst.net.nz>
Subject: Re: [PATCH 1/2] git-svn: add (failing) test for SVN 1.5+ merge with intervening commit
Date: Sun, 15 Nov 2009 17:30:13 -0800	[thread overview]
Message-ID: <20091116013013.GA3829@dcvr.yhbt.net> (raw)
In-Reply-To: <87k4xrb785.fsf@navakl084.mitacad.com>

Toby Allsopp <Toby.Allsopp@navman.co.nz> wrote:
> [Dropped Junio from CC]
> 
> On Sun, Nov 15 2009, Eric Wong wrote:
> 
> > Hi Toby,
> >
> > Thanks for this series, acked and squashed into a single commit to avoid
> > unnecessary bisection failures at git://git.bogomips.org/git-svn
> 
> Great, thanks.  I have no objection to being squashed, but I'm not sure
> what you mean by bisection failures.  Does a test_expect_failure cause
> problems for bisection?  It appears to be fairly common to introduce a
> failing test case and later fix it, e.g. ce06461 then 751c597.  I'd just
> like to understand any potential problems with what I did.

Oops.  I didn't even notice you had test_expect_failure there :x
I'll just leave it as is incase somebody has already pulled from me
(other, unrelated patches coming in a few)

-- 
Eric Wong

      reply	other threads:[~2009-11-16  1:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 20:48 [PATCH 1/2] git-svn: add (failing) test for SVN 1.5+ merge with intervening commit Toby Allsopp
2009-11-14 21:40 ` Eric Wong
2009-11-16  1:15   ` Toby Allsopp
2009-11-16  1:30     ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091116013013.GA3829@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=Toby.Allsopp@navman.co.nz \
    --cc=git@vger.kernel.org \
    --cc=sam.vilain@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox