git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Doc: mention the crlf attribute in config autocrlf section
Date: Mon, 16 Nov 2009 20:59:45 -0700	[thread overview]
Message-ID: <20091117035945.GA1728@comcast.net> (raw)
In-Reply-To: <20091116195048.6117@nanako3.lavabit.com>

On Mon, Nov 16, 2009 at 07:50:48PM +0900, Nanako Shiraishi wrote:
> Quoting Matthew Ogilvie <mmogilvi_git@miniinfo.net>
> 
> > The reverse reference has long existed, and the autocrlf description
> > was actually obsolete and wrong (saying only file content is used),
> > not just incomplete.
> 
> What do you mean by "reverse reference"?
> 

I'm refering to the fact that the "crlf" section of
Documentation/gitattributes.txt mentions core.autocrlf,
which is in the opposite (reverse) direction as this new reference
I'm adding.

The crlf section has a much more thorough description of
the various knobs and settings and how they interact.  But
I just checked, and although the gitattributes crlf section
describes core.autocrlf in reasonable detail, it does not have an
actual link (reference?) to git-config or the core.autocrlf
section.  So the commit message isn't as clear as it could be.

Do I need to resubmit the patch, in order to rephrase the commit
message?

--
Matthew Ogilvie   [mmogilvi_git@miniinfo.net]

  reply	other threads:[~2009-11-17  4:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14 18:35 [PATCH] Doc: mention the crlf attribute in config autocrlf section Matthew Ogilvie
2009-11-16 10:50 ` Nanako Shiraishi
2009-11-17  3:59   ` Matthew Ogilvie [this message]
2009-11-17  6:37     ` Junio C Hamano
2009-11-17  7:43       ` Matthew Ogilvie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091117035945.GA1728@comcast.net \
    --to=mmogilvi_git@miniinfo.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).