From: Christian Couder <chriscool@tuxfamily.org>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>,
Jakub Narebski <jnareb@gmail.com>, bill lam <cbill.lam@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] replace: use a GIT_NO_REPLACE_OBJECTS env variable
Date: Wed, 18 Nov 2009 07:48:41 +0100 [thread overview]
Message-ID: <200911180748.42061.chriscool@tuxfamily.org> (raw)
In-Reply-To: <4B0253DA.1090003@viscovery.net>
On mardi 17 novembre 2009, Johannes Sixt wrote:
> Christian Couder schrieb:
> > diff --git a/git.c b/git.c
> > index bd2c5fe..7f7d73d 100644
> > --- a/git.c
> > +++ b/git.c
> > @@ -89,6 +89,9 @@ static int handle_options(const char ***argv, int
> > *argc, int *envchanged) *envchanged = 1;
> > } else if (!strcmp(cmd, "--no-replace-objects")) {
> > read_replace_refs = 0;
> > + setenv(NO_REPLACE_OBJECTS_ENVIRONMENT, "", 1);
>
> It is safer to set to a non-empty string, e.g., "1".
Ok, I will use a non empty string.
> I think this variable should be added to the list in connect.c around
> line 630 so that it does not propagate to the remote end.
Ok, I have done that in the version I will send.
Thanks,
Christian.
next prev parent reply other threads:[~2009-11-18 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 5:11 [PATCH 1/2] replace: use a GIT_NO_REPLACE_OBJECTS env variable Christian Couder
2009-11-17 7:42 ` Johannes Sixt
2009-11-18 6:48 ` Christian Couder [this message]
2009-11-17 9:33 ` Michael J Gruber
2009-11-18 6:49 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911180748.42061.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=cbill.lam@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jnareb@gmail.com \
--cc=paulus@samba.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).