git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Potapov <dpotapov@gmail.com>
To: david@lang.hm
Cc: "George Dennie" <gdennie@pospeople.com>,
	"'Jason Sewall'" <jasonsewall@gmail.com>,
	"'Jakub Narebski'" <jnareb@gmail.com>, "'Jan Krüger'" <jk@jk.gs>,
	git@vger.kernel.org
Subject: Re: Hey - A Conceptual Simplication....
Date: Fri, 20 Nov 2009 05:56:18 +0300	[thread overview]
Message-ID: <20091120025617.GD22556@dpotapov.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0911191754540.10307@asgard.lang.hm>

On Thu, Nov 19, 2009 at 05:55:21PM -0800, david@lang.hm wrote:
> On Fri, 20 Nov 2009, Dmitry Potapov wrote:
>
>> So, the correct way to use Git is to find the right balance between
>> the need to clean up after mistakes (using git-rebase) and not doing
>> too much, so you will not lose important history or create problems
>> for other peoples.
>
> the typical advice is to clean up before you make changes public, but not 
> afterwords.

True, except patches may get additional clean up or improvements based
on review feedback, or even get some small fix-ups while they live on
'pu'. But re-writing something that other people may base their work on
is clearly wrong. On the other hand, rebasing a large series of patches
even if it has never been published may be a wrong way to go, because
you replace well tested states with some others, which were not tested.
So if it is a long and complex series of patches, chances are high that
you can break something in it. So, it requires some judgement when to
use git-rebase and when git-merge.


Dmitry

  reply	other threads:[~2009-11-20  2:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 12:55 Hey - A Conceptual Simplication George Dennie
2009-11-18 13:18 ` Jonathan del Strother
2009-11-18 13:25 ` Jan Krüger
2009-11-18 18:51   ` George Dennie
2009-11-18 19:40     ` Jakub Narebski
2009-11-18 19:52       ` Jason Sewall
2009-11-19  2:03         ` George Dennie
2009-11-19  7:42           ` Björn Steinbrink
2009-11-19 20:12             ` George Dennie
2009-11-19 21:27               ` Junio C Hamano
2009-11-20  0:49               ` Jakub Narebski
2009-11-20  6:27                 ` Junio C Hamano
2009-11-20  2:31               ` Dmitry Potapov
2009-11-19 10:27           ` Jakub Narebski
2009-11-20  1:48           ` Dmitry Potapov
2009-11-20  1:55             ` david
2009-11-20  2:56               ` Dmitry Potapov [this message]
2009-11-20  2:35             ` Björn Steinbrink
2009-11-20  3:08               ` Dmitry Potapov
2009-11-20  1:35     ` Dmitry Potapov
2009-11-20  6:33       ` Junio C Hamano
2009-11-20 15:07         ` Dmitry Potapov
2009-11-18 13:30 ` Thomas Rast
2009-11-18 13:31 ` Jason Sewall
2009-11-18 20:36 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091120025617.GD22556@dpotapov.dyndns.org \
    --to=dpotapov@gmail.com \
    --cc=david@lang.hm \
    --cc=gdennie@pospeople.com \
    --cc=git@vger.kernel.org \
    --cc=jasonsewall@gmail.com \
    --cc=jk@jk.gs \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).