git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Jeff King <peff@peff.net>
Cc: bill lam <cbill.lam@gmail.com>, Nicolas Pitre <nico@fluxnic.net>,
	git <git@vger.kernel.org>
Subject: Re: how to suppress progress percentage in git-push
Date: Mon, 23 Nov 2009 18:05:47 +0100	[thread overview]
Message-ID: <20091123170547.GC26996@machine.or.cz> (raw)
In-Reply-To: <20091123164319.GA23011@sigill.intra.peff.net>

On Mon, Nov 23, 2009 at 11:43:19AM -0500, Jeff King wrote:
> On Mon, Nov 23, 2009 at 04:50:43PM +0100, Petr Baudis wrote:
> 
> > On Mon, Nov 23, 2009 at 10:00:00AM -0500, Jeff King wrote:
> > > The patch for (1) would look something like what's below.  It's simpler,
> > > but it does change the semantics; anyone who was relying on
> > > --all-progress to turn on progress unconditionally would need to now
> > > also use --progress. However, turning on progress unconditionally is
> > > usually an error (the except is if you are piping output in real-time to
> > > the user and need to overcome the isatty check).
> > 
> > I'm actually doing exactly that in the mirrorproj.cgi of Girocco, so I
> > would be unhappy if I would have to go through creating ptys or whatever
> > now. Maybe conditioning this by an environment variable?
> 
> You wouldn't need to do anything that drastic. You would just need to
> pass "--progress --all-progress" instead of only --all-progress. But you
> have provided the data point that such a change would break at least one
> user.
> 
> We could also leave --all-progress as-is and add new option to mean "if
> you are already doing progress, do all progress".

Hmm, maybe I'm confused - I just call

	git remote update

and don't pass any progress switches - would your change still affect
me? Can I pass --progress to `git remote update`?

-- 
				Petr "Pasky" Baudis
A lot of people have my books on their bookshelves.
That's the problem, they need to read them. -- Don Knuth

  reply	other threads:[~2009-11-23 17:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22 14:53 how to suppress progress percentage in git-push bill lam
2009-11-23 15:00 ` Jeff King
2009-11-23 15:50   ` Petr Baudis
2009-11-23 16:43     ` Jeff King
2009-11-23 17:05       ` Petr Baudis [this message]
2009-11-23 19:28         ` Jeff King
2009-11-23 17:43       ` [PATCH] pack-objects: split implications of --all-progress from progress activation Nicolas Pitre
2009-11-23 18:12         ` Petr Baudis
2009-11-23 18:27           ` Nicolas Pitre
2009-11-23 19:04             ` Petr Baudis
2009-11-23 19:32         ` Jeff King
2009-11-23 16:56   ` how to suppress progress percentage in git-push Nicolas Pitre
2009-11-23 19:25     ` Jeff King
2009-11-23 19:40       ` Nicolas Pitre
2009-11-24  1:13     ` bill lam
2009-11-24  3:07       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123170547.GC26996@machine.or.cz \
    --to=pasky@suse.cz \
    --cc=cbill.lam@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).