Re: how to suppress progress percentage in git-push

[Jeff King <peff@peff.net>]

On Mon, Nov 23, 2009 at 11:56:43AM -0500, Nicolas Pitre wrote:

> > We need to do one of:
> > 
> >   1. make --all-progress imply "if we are using progress, then make it
> >      more verbose. Otherwise, ignore."
> > 
> >   2. fix all callers to check isatty(2) before unconditionally passing
> >      the option
> 
> None of the above would fix the issue as this only affects progress 
> display for phase #3.  You'd still get progress display for the counting 
> phase and the compressing phase.

I think it does fix the issue, as it is exactly the side effect that we
are concerned about (and I tested my patch for 1, which squelched it).
But your --all-progress-implied is a better fix, so I think we should go
with that.

> That doesn't mean it is OK for send-pack to unconditionally use 
> --all-progress though, although it does provide the -q argument to 
> pack-objects when push -q is used which inhibits any progress display 
> already.

It does, and I almost suggested that (although -q is new as of 1.6.5, so
it may not help the original poster). But "-q" actually does more than
that; it also silences any output for a successful push, which may not
be desired.

-Peff